Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes in probalistic modeling examples section #2661

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

m-balesdent
Copy link
Collaborator

@m-balesdent m-balesdent commented May 17, 2024

This PR proposes to correct typos on the probabilistic modeling section of Examples

image

The 50 examples of this section have been reviewed and several dozens of typos have been fixed.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (b5fd833) to head (02289fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2661   +/-   ##
=======================================
  Coverage   78.47%   78.47%           
=======================================
  Files         840      840           
  Lines       96641    96641           
=======================================
  Hits        75836    75836           
  Misses      20805    20805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-balesdent m-balesdent marked this pull request as ready for review May 21, 2024 06:32
Copy link
Collaborator

@mbaudin47 mbaudin47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this work. I have only minor suggestions.

@@ -5,40 +5,40 @@
# %%
# In this example we are going to estimate a trend from a field.
#
# We note :math:`(\underline{x}_0, \dots, \underline{x}_{N-1})` the values of
# We note :math:`(\vect{x}_0, \dots, \vect{x}_{N-1})` the values of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better formatting indeed.

Before:

image

After:

image

Thank you!

m-balesdent and others added 10 commits May 27, 2024 11:30
…create_extreme_value_distribution.py

Co-authored-by: Michael Baudin <[email protected]>
…create_random_mixture.py

Co-authored-by: Michael Baudin <[email protected]>
…create_random_mixture.py

Co-authored-by: Michael Baudin <[email protected]>
…create_extreme_value_distribution.py

Co-authored-by: Michael Baudin <[email protected]>
…create_your_own_dist.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_userdefined_covariance_model.py

Co-authored-by: Michael Baudin <[email protected]>
…create_and_draw_scalar_distributions.py

Co-authored-by: Michael Baudin <[email protected]>
…_python_randomvector.py

Co-authored-by: Michael Baudin <[email protected]>
m-balesdent and others added 9 commits May 27, 2024 11:32
…s/plot_create_and_manipulate_arma_process.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_and_manipulate_arma_process.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_and_manipulate_arma_process.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_and_manipulate_arma_process.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_stationary_covmodel.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_stationary_covmodel.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_stationary_covmodel.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_create_stationary_covmodel.py

Co-authored-by: Michael Baudin <[email protected]>
…s/plot_process_manipulation.py

Co-authored-by: Michael Baudin <[email protected]>
Copy link
Collaborator

@adutfoy adutfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review!

@m-balesdent m-balesdent requested review from adutfoy and removed request for adutfoy June 4, 2024 14:37
Copy link
Collaborator

@josephmure josephmure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Once you apply these last suggestions, it will be good to go IMO.

m-balesdent and others added 8 commits June 6, 2024 15:52
…create_draw_multivariate_distributions.py

Co-authored-by: josephmure <[email protected]>
…create_draw_multivariate_distributions.py

Co-authored-by: josephmure <[email protected]>
…create_draw_multivariate_distributions.py

Co-authored-by: josephmure <[email protected]>
…minimum_volume_level_sets.py

Co-authored-by: josephmure <[email protected]>
…minimum_volume_level_sets.py

Co-authored-by: josephmure <[email protected]>
…s/plot_create_normal_process.py

Co-authored-by: josephmure <[email protected]>
…s/plot_process_manipulation.py

Co-authored-by: josephmure <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants