-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOLA-Voronoi #2566
base: master
Are you sure you want to change the base?
LOLA-Voronoi #2566
Conversation
3626a0f
to
189a9a5
Compare
aefb302
to
28ef9cf
Compare
dc81231
to
35277ea
Compare
Maybe adding a specific test with nanoflann enabled ? |
I can't disable nanoflann at runtime: either nanoflann is enabled at buildtime if available, either its the regular implementation. anyway they give the same results. but both are tested since nanoflann is not available on the mindeps job for example |
ok |
51e2865
to
7c442f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only checked the nanoflann part in details. IMO it should be part of the next release and should be merged, while the remaining of the code is for a longer term.
0108347
to
3510db9
Compare
eefa06e
to
978069d
Compare
cb74eac
to
51f664d
Compare
@@ -41,6 +41,7 @@ | |||
%include ChiSquare.i | |||
%include ChiSquareFactory.i | |||
%include CompositeDistribution.i | |||
%include CombinationsDistribution.i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the experimental module. I fixed it in the commit related to the MarginalUniformOrderStatistics, my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it would be easier to squash the CombinationsDistribution commits
.. math:: | ||
:nowrap: | ||
|
||
\begin{eqnarray*} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These formulas are a copy/paste from KPermutationsDistribution, Anne has to change it into my branch soon
...c/Uncertainty/Algorithm/Optimization/openturns/SequentialSamplingAlgorithmImplementation.hxx
Outdated
Show resolved
Hide resolved
/** String converter */ | ||
String __repr__() const override; | ||
|
||
// Generate new samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Generate new samples | |
// Generate a new sample |
I see that the IMO, this algorithm is quite generic and could be the base for other types of goal-oriented algorithms in the future. For example, AK methods follow the same architecture. Thus, maybe this base class could be moved outside the |
This multivariate discrete distribution is the uniform distribution over the set of strictly increasing functions from {0,...,k-1} to {0,...,n-1} where k and n are natural numbers such that k<=n. It is also the uniform distribution over the subsets of size k of a set of size n.
Now it has a isStrictlyIncreasing() method.
implements crombecq2011