Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复画布行列容器组件中的分割工具位置错误的问题 #458

Merged
merged 7 commits into from
May 17, 2024

Conversation

gene9831
Copy link
Collaborator

@gene9831 gene9831 commented Apr 28, 2024

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

修改画布相对位置时引入的一个Bug,导致布行列容器组件中的分割工具位置错误

What is the current behavior?

image

What is the new behavior?

  1. 重构了画布坐标系
  2. 优化了画布右键菜单

和引入Bug前的UI保持一致
image
drag-canvas-row

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@chilingling chilingling added ready_for_review This PR requires more reviews bug Something isn't working labels Apr 28, 2024
chilingling
chilingling previously approved these changes Apr 29, 2024
@w990752800
Copy link

纵向分割大于2的时候报错:
image

chilingling
chilingling previously approved these changes May 11, 2024
@chilingling chilingling merged commit 0d36df0 into opentiny:develop May 17, 2024
2 checks passed
@gene9831 gene9831 deleted the fix/canvas-row-cutter-position branch May 27, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready_for_review This PR requires more reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants