feat: ingest Loss-of-Function variant data from OTAR2075 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -150,6 +150,7 @@ nodes: | |||
| step.variant_index_path: '{release_dir}/variant_index' | |||
| step.amino_acid_change_annotations: | |||
| - gs://otar013-ppp/OTAR2081_foldx/foldx_variant_annotation | |||
| step.lof_curation_variant_annotations_path: gs://otar013-ppp/OTAR2075_lof_curation/lof_curation_variant_annotations | |||
There was a problem hiding this comment.
Should that not be another annotation in the list above for consistency?
There was a problem hiding this comment.
These are different types: one is an AminoAcidVariants object and one is a VariantIndex object so should be separate inputs
There was a problem hiding this comment.
I see your point, thus we already have another variant index from gnomad.
There was a problem hiding this comment.
Ah I see what you mean. I can add it to the variant_index_path instead of it being a separate parameter
| dataproc: | ||
| python_main_module: gs://genetics_etl_python_playground/initialisation/cli.py | ||
| cluster_metadata: | ||
| GENTROPY_REF: v2.0.1 |
There was a problem hiding this comment.
Given that v2.1.0 is already out, I think we have to freeze the gentropy first after your PR is merged before we can merge this.
|
@vivienho please see the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new DAG to ingest LOF variant data curated in OTAR2075. The ingested output is provided as an input to the variant_index step to annotate an existing variant index.