Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configure tabbar max visible counts #3691

Merged
merged 2 commits into from
May 17, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Background or solution

场景是这样, opensumi 只是我们的一个 tab,但这个 tab 会提前渲染,这个时候 tabbar 的高度是 0(应该是有 bug),然后我们切换到这个 tab 的时候,这个 tab 的高度是没变的

Changelog

allow configure tabbar max visible counts

Copy link

railway-app bot commented May 17, 2024

🚅 Previously deployed to Railway in the main project. Environment has been deleted.

@opensumi opensumi bot added the 🎨 feature feature required label May 17, 2024
@bytemain
Copy link
Member Author

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 17, 2024

🎉 PR Next publish successful!

3.0.2-next-1715934583.0

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.05%. Comparing base (4d40f20) to head (e7a9d1f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3691   +/-   ##
=======================================
  Coverage   56.05%   56.05%           
=======================================
  Files        1514     1514           
  Lines       92201    92201           
  Branches    18895    18895           
=======================================
+ Hits        51684    51687    +3     
+ Misses      33618    33616    -2     
+ Partials     6899     6898    -1     
Flag Coverage Δ
jsdom 51.45% <ø> (+<0.01%) ⬆️
node 15.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hacke2 hacke2 merged commit 4752c7e into main May 17, 2024
13 checks passed
@hacke2 hacke2 deleted the feat/allow-configure-tabbar-max-visible-count branch May 17, 2024 09:37
bytemain added a commit that referenced this pull request May 21, 2024
* feat: allow configure tabbar max visible counts

* chore: update type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants