Add status filter to user's note page

[kcne]

Description

This PR partly addresses #832 and serves as a smaller alternative to #5255 as suggested in comments. It aims to enhance user experience on user note pages by providing filtering functionality for notes by status. The with_status scope is added to the Note model, and the NotesController is updated accordingly. Default behavior remains unchanged since the status preselected value is set to All by default.

How has this been tested?

Test for the new scope is added to note model test to ensure functionality is working as expected.

Screenshots

[tomhughes]

In addition to the inline comment this could do with tests at the controller or system level rather than just testing the model method.

[tomhughes]

Rather than trying to handle the all case specially here I think I would make this much simpler, like the with_status on the issue model, and then add an unless params[:status] == "all" guard in the controller so that the filter isn't applied when all statuses are requested.

[AntonKhorev]

Do we even need the scope? A similar scope for issues is not used by the issues controller:

openstreetmap-website/app/controllers/issues_controller.rb

Line 37 in e15a92a

@issues = @issues.where(:status => params[:status]) if params[:status].present?

[kcne]

Fixed and updated the PR. Since this is the only place using the scope, I removed it to simplify the code and maintain consistency. If a need arises, we can reintroduce it later.

Also, I’ve added a test in the controller to cover the basic status filtering functionality. Let me know if further tests are needed.