Note subscriptions #5283
Draft
Note subscriptions #5283
+320
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
note-subscriptions
branch
2 times, most recently
from
3b1657c
to
1de0127
Compare
AntonKhorev
force-pushed
the
note-subscriptions
branch
4 times, most recently
from
df53ca0
to
f79120a
Compare
AntonKhorev
force-pushed
the
note-subscriptions
branch
from
f79120a
to
9bd3f06
Compare
AntonKhorev
force-pushed
the
note-subscriptions
branch
from
9bd3f06
to
2624faa
Compare
AntonKhorev
force-pushed
the
note-subscriptions
branch
from
2624faa
to
a366fde
Compare
AntonKhorev
force-pushed
the
note-subscriptions
branch
from
a366fde
to
d3e2d46
Compare
AntonKhorev
force-pushed
the
note-subscriptions
branch
from
d3e2d46
to
ffdeb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a subscription functionality to notes, similar to changesets and diary entry subscriptions.
Without this it's impossible to unsubscribe from notes you may not care about. If you did any mass note manipulation in some area, chances are someone else will start altering these notes later. In this case you'll receive waves of emails and there's no way to stop them.
See also https://osmfoundation.org/wiki/Operations/Minutes/2024-05-02#Discussion_on_spam_reports_via_ISP. "Encourage Microsoft to work on maintaining separate subscriptions for notes, as there was some work already done by them on refactoring the way notes are presented and they are interested in improving the notes." - I'm not sure what work on notes was done by Microsoft at that time.
Needs to be merged in at least two parts because backfilling. Backfilling is done in a migration here which may not be the best idea. We already did data migrations like that but they were simpler.