Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display old node versions on map view #5278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

Shows node versions like in #4930 but without complications #4930 (comment) and without saving api calls.

image

Copy link
Contributor

@nenad-vujicic nenad-vujicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great on my side, thanks!

I believe similar changes to remaining OSM.OldBrowse() occurrences will enable displaying old ways / relations versions? :-)

Q: I found one strange behavior with nodes / ways / relations pagination controls. They initially display "Version 1" and "last version", although they should perhaps display only "previous version" link initially. Is this expected behavior? I apologize for bad place for posting this, but didn't want to create new issue if behavior is expected.

image

@AntonKhorev
Copy link
Collaborator Author

I believe similar changes to remaining OSM.OldBrowse() occurrences will enable displaying old ways / relations versions? :-)

As soon as #4930 (comment) is done.

Q: I found one strange behavior with nodes / ways / relations pagination controls. They initially display "Version 1" and "last version", although they should perhaps display only "previous version" link initially.

But before that thing is done, current version without a number and version with the last number are really different pages, although the UI is probably not the best here. See also #4946.

@AntonKhorev AntonKhorev added the mapview Related to the map view features label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mapview Related to the map view features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants