Send <head> along with pagination frames #5175
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous/next page visits are promoted to full page visits with Turbo rewriting most of <head> tags. If new tags aren't sent together with the updated frame, old ones will be simply deleted. That includes deleting a page title and csrf token tags, which is going to break some functionality, particularly logouts.
|
Tried There's one more problem with either resending |
|
Duplicate tab is also broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things broken by Turbo pagination part 2, the previous part is #5111.
Previous/next page visits are promoted to full page visits with Turbo rewriting most of
<head>tags. If new tags aren't sent together with the updated frame, old ones will be simply deleted. That includes deleting a page title and csrf token tags, which is going to break some functionality, particularly logouts. See hotwired/turbo#1237.Open any page with Turbo pagination, click Older/Newer link, notice that the page title is gone. Then click Logout and it's not going to work. #4646 (comment) worked correctly for changeset elements pagination because it's not promoted to page visits.