code review changes

openstreetmap · Feb 12, 2025 · f74a006 · f74a006
1 parent d9bbb00
commit f74a006
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/data/core.yaml b/data/core.yaml
@@ -1989,7 +1989,7 @@ en:
       continue_from_end:
         title: Continue drawing from end
       tag_as_entrance:
-        title: Mark the endpoint as a {presetName}
+        title: Mark the endpoint as “{presetName}”
       convert_to_line:
         title: Convert this to a line
         annotation: Converted an area to a line.

diff --git a/modules/validations/disconnected_way.js b/modules/validations/disconnected_way.js
@@ -229,9 +229,10 @@ export function validationDisconnectedWay() {
                 // ineligible for this fix
                 if (!isConnectedToBuilding) continue;
 
-                const entranceTags = highway.tags.highway in osmPathHighwayTagValues
-                    ? { entrance: 'yes' }
-                    : { amenity: 'parking_entrance' };
+                // this autofix is only supported for paths
+                if (!(highway.tags.highway in osmPathHighwayTagValues)) continue;
+
+                const entranceTags = { entrance: 'yes' };
 
                 const presetName = presetManager.matchTags(entranceTags, 'vertex').name();
 

diff --git a/test/spec/validations/disconnected_way.js b/test/spec/validations/disconnected_way.js
@@ -101,7 +101,7 @@ describe('iD.validations.disconnected_way', function () {
     });
 
     describe.each([
-        ['unclassified', { amenity: 'parking_entrance' }],
+        // ['unclassified', { amenity: 'parking_entrance' }],
         ['path', { entrance: 'yes' }]
     ])('highway=%s -> %s', (highway, entranceTags) => {
         it('suggests adding an entrance node if the isolated highway network touches a building outline', () => {