Disable 70-test_quic_multistream.t when building with PUT threads. #24468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
approved these changes
May 22, 2024
paulidale
added
branch: master
t8m
added
triaged: bug
nhorman
approved these changes
May 23, 2024
|
Any chance this could get merged to 3.3.1? |
t8m
added
approval: done
t8m
requested changes
May 29, 2024
The test recipe includes a TEST_skip when OpenSSL is built with _PUT_MODEL_ based on design assumptions for QUIC and incompatibility with PUT wrapper methods. This fix also reverts b9e084f that added OP_SLEEP to force a yield. Fixes: openssl#24442 Fixes: openssl#24431 Signed-off-by: Randall S. Becker <[email protected]>
t8m
approved these changes
May 30, 2024
t8m
added
the
approval: review pending
|
@nhorman @paulidale please reconfirm |
|
Ack approval holds |
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master, 3.3 and 3.2 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 4, 2024
The test recipe includes a TEST_skip when OpenSSL is built with _PUT_MODEL_ based on design assumptions for QUIC and incompatibility with PUT wrapper methods. Fixes: #24442 Fixes: #24431 Signed-off-by: Randall S. Becker <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24468) (cherry picked from commit 0e2567d)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 4, 2024
The test recipe includes a TEST_skip when OpenSSL is built with _PUT_MODEL_ based on design assumptions for QUIC and incompatibility with PUT wrapper methods. Fixes: #24442 Fixes: #24431 Signed-off-by: Randall S. Becker <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24468) (cherry picked from commit 0e2567d)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 4, 2024
The test recipe includes a TEST_skip when OpenSSL is built with _PUT_MODEL_ based on design assumptions for QUIC and incompatibility with PUT wrapper methods. Fixes: #24442 Fixes: #24431 Signed-off-by: Randall S. Becker <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test recipe includes a TEST_skip when OpenSSL is built with PUT_MODEL based on design assumptions for QUIC and incompatibility with PUT wrapper methods. This fix also reverts b9e084f that added OP_SLEEP to force a yield.
Fixes: #24442
Fixes: #24431
Checklist