crypto/riscvcap: fix function declaration for hwprobe_to_cap #24373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: function declaration isn't a prototype [-Werror=strict-prototypes] Fixes: 66ad636 ("riscv: use hwprobe syscall for capability detection")
github-actions
bot
added
the
severity: fips change
paulidale
approved these changes
May 12, 2024
paulidale
added
branch: master
t8m
added
triaged: bug
t8m
approved these changes
May 13, 2024
t8m
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged to the master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
May 14, 2024
error: function declaration isn't a prototype [-Werror=strict-prototypes] Fixes: 66ad636 ("riscv: use hwprobe syscall for capability detection") Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with gcc from ubuntu 24.04 with
--strict-warnings, it would complainThis was found during an attempt to migrate riscv64 cross-compile CI for openssl to ubuntu 24.04. In 24.04, the header
<asm/hwprobe.h>exists so the#ifdeffor this function was enabled, whereas it is not the case for 22.04.Checklist