Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Provider compat CI and sslapitest with FIPS provider #24347

Closed
wants to merge 3 commits into from
Closed

Fix Provider compat CI and sslapitest with FIPS provider #24347

wants to merge 3 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented May 8, 2024

No description provided.

@t8m t8m force-pushed the fix-provider-compat-ci branch from e05477e to 9fd4229 Compare May 8, 2024 13:42
@paulidale
Copy link
Contributor

I prefer this approach I think.

@nhorman nhorman linked an issue May 9, 2024 that may be closed by this pull request
Provider compat CI is broken because of X25519/X448 having fips=no on master #24246
Open
t8m added 2 commits May 10, 2024 14:50
@t8m
90-test_sslapi.t: Fix execution of sslapitest with fips provider
a139a07 
Default configuration of the fips provider for tests is pedantic
which means that sslapitest was not fully executed with fips provider.

The ems check must be switched off for full execution.
@t8m
sslapitest.c: With fips skip tests depending on X25519 and X448
c0dd1f9
@t8m t8m changed the title Fix Provider compat CI Fix Provider compat CI and sslapitest with FIPS provider May 10, 2024
@t8m t8m added branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels May 10, 2024
@t8m t8m marked this pull request as ready for review May 10, 2024 13:27
@t8m t8m requested a review from paulidale May 10, 2024 13:27
@t8m t8m added tests: present The PR has suitable tests present and removed tests: exempted The PR is exempt from requirements for testing labels May 10, 2024
@t8m t8m mentioned this pull request May 10, 2024
Closed
@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label May 10, 2024
@t8m t8m requested a review from a team May 13, 2024 06:42
tom-cosgrove-arm
tom-cosgrove-arm approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 13, 2024
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label May 14, 2024
@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label May 14, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
Add 3.2 and 3.3 branches to Provider compat CI
887572b 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
90-test_sslapi.t: Fix execution of sslapitest with fips provider
d2af5e4 
Default configuration of the fips provider for tests is pedantic
which means that sslapitest was not fully executed with fips provider.

The ems check must be switched off for full execution.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
sslapitest.c: With fips skip tests depending on X25519 and X448
f6e4698 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
90-test_sslapi.t: Fix execution of sslapitest with fips provider
fa30357 
Default configuration of the fips provider for tests is pedantic
which means that sslapitest was not fully executed with fips provider.

The ems check must be switched off for full execution.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit d2af5e4)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
sslapitest.c: With fips skip tests depending on X25519 and X448
843d42b 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit f6e4698)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
90-test_sslapi.t: Fix execution of sslapitest with fips provider
4fd2fa3 
Default configuration of the fips provider for tests is pedantic
which means that sslapitest was not fully executed with fips provider.

The ems check must be switched off for full execution.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit d2af5e4)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
sslapitest.c: With fips skip tests depending on X25519 and X448
4471636 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit f6e4698)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
90-test_sslapi.t: Fix execution of sslapitest with fips provider
fb3b7f9 
Default configuration of the fips provider for tests is pedantic
which means that sslapitest was not fully executed with fips provider.

The ems check must be switched off for full execution.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit d2af5e4)
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
sslapitest.c: With fips skip tests depending on X25519 and X448
2ae3b0b 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit f6e4698)
@t8m
Copy link
Member Author

t8m commented May 14, 2024

Merged to all the active branches. Thank you for the reviews.

@t8m t8m closed this May 14, 2024
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@t8m
sslapitest.c: With fips skip tests depending on X25519 and X448
d80296d 
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
(Merged from #24347)

(cherry picked from commit f6e4698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnox xnox xnox left review comments

@paulidale paulidale paulidale approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@cklim5 cklim5 cklim5 approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider compat CI is broken because of X25519/X448 having fips=no on master
6 participants
@t8m @paulidale @openssl-machine @xnox @tom-cosgrove-arm @cklim5