Skip to content

fix low level setting - add null check for attribute name #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zaqifathis
Copy link
Collaborator

sample test file: Tests/test/org/bimserver/tests/lowlevel/TestCreateLists.java

@hlg
Copy link
Member

hlg commented Mar 10, 2025

This might make the test running without failure, but I am not so sure whether this is the behavior we want or whether the ...AsString list should be created in the first place (earlier in the test, during is applying AddAttributeChange). Uploading a file always keeps original strings for doubles in "...AsString" attributes, but the low level methods seem to be a bit inconsistent. Other methods might rely on this as well. Although IFC serializers apparently don't rely on the ...AsString attributes to be set, implementation of issue #765, would require them to be always set, for example.

Also this is an example of a test that does too much, so if something fails, it is not clear what is the failure. Adding assertions about the ..AsString attributes might mitigate this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants