Proposal to use a socket server based on select for receiving data. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided implemention has been tested with SSDP, and is implemented for DGR and SSDP. It could be used for ANY sockets - e.g. it could be used for the http server, to accept http connections.
|
Hi @btsimonh - just wanted to confirm I'm using this socket server implementation for both of my |
|
Can you create a pull request so I can test it?
śr., 12 kwi 2023 o 11:04 Linus Go ***@***.***> napisał(a):
… Hi @btsimonh <https://github.com/btsimonh> - just wanted to confirm I'm
using this socket server implementation for both of my BK7231N Tuya bulbs
and I've noticed a huge increase in performance/speed.
—
Reply to this email directly, view it on GitHub
<#550 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUMGZ64BRP4G6LVHMJPSSXTXAZVYRANCNFSM6AAAAAATCQJAXY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Hi @openshwprojects, to clarify do you want a PR with these changes, with the latest master merged into it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided implemention has been tested with SSDP, and is implemented for DGR and SSDP. It could be used for ANY sockets - e.g. it could be used for the http server, to accept http connections.
Logs could be reduced, but it's clean and functional.
We should check stack usage...