Red Hat Konflux update source-to-image-rhel9 #1223
Conversation
![red-hat-konflux[bot]](https://avatars.githubusercontent.com/in/296509?s=60&v=4){kind=small}
Signed-off-by: red-hat-konflux <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
needs-ok-to-test
| appstudio.openshift.io/application: source-to-image | ||
| appstudio.openshift.io/component: source-to-image-rhel9 | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: source-to-image-rhel9-on-pull-request |
There was a problem hiding this comment.
This name is correct. But we need to rename the existing one to source-to-image-rhel8-on-pull-request
| pipelinesascode.tekton.dev/cancel-in-progress: "true" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "pull_request" && target_branch | ||
| == "master" |
There was a problem hiding this comment.
Add CEL expression to exclude changes from RHEL8 docker file. Need the same in the rhel8 pipeline for rhel9 dockerfile.
| - name: dockerfile | ||
| value: Dockerfile.rhel9 | ||
| pipelineSpec: | ||
| description: | |
There was a problem hiding this comment.
We need use the remote-pipeline pattern here.
https://konflux-ci.dev/docs/patterns/keep-remote-pipelines-up-to-date/
Our pipelines are here in this repo. Use this pipeline for multiarch build.
https://github.com/redhat-openshift-builds/release/blob/main/pipelines/konflux-build-multi-platform.yaml
This change required for rhel8 pipelines also.
|
Close in favor of #1224 |
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-testFor more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization