-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-1574: Server Side Views #1614
base: master
Are you sure you want to change the base?
Conversation
Introduce the API for server side views, providing a centralized concept for views over the CR data.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dgoodwin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dgoodwin: This pull request references TRT-1574 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold We're working out how to use the variant registry in component readiness, which will impact the structure of these views. This can be reviewed but we'll hold off on merging until we get a final structure. |
Server now accepts a CLI param for
--component-readiness-views views.yaml
.Adds a new /api/component_readiness/views API call to list these views, and their params. This is intended for future use in the UI to list params, and allow a user to stop using the view but tweak it's settings to get their own custom URL.
/api/component_readiness now accepts a ?view=main param. If specified, all the params above should conflict with the fact you specified a view.
Thus far, start/end times are not part of the view, this will be up for discussion with the team. base and sample release are both still required, we may make base optional and assume to use sample-1 if sample is not GA yet, or sampleGA if it is.