Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1574: Server Side Views #1614

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Apr 17, 2024

Server now accepts a CLI param for --component-readiness-views views.yaml.

---
- name: main
  variant_options:
    group_by: ''
    platform: ''
    upgrade: ''
    arch: ''
    network: ''
    variant: ''
  exclude_options:
    exclude_platforms: ''
    exclude_arches: ''
    exclude_networks: ''
    exclude_upgrades: ''
    exclude_variants: ''
  advance_options:
    minimum_failure: 0
    confidence: 0
    pity_factor: 0
    ignore_missing: false
    ignore_disruption: false

Adds a new /api/component_readiness/views API call to list these views, and their params. This is intended for future use in the UI to list params, and allow a user to stop using the view but tweak it's settings to get their own custom URL.

/api/component_readiness now accepts a ?view=main param. If specified, all the params above should conflict with the fact you specified a view.

Thus far, start/end times are not part of the view, this will be up for discussion with the team. base and sample release are both still required, we may make base optional and assume to use sample-1 if sample is not GA yet, or sampleGA if it is.

@dgoodwin dgoodwin changed the title server views poc Server Side Views Apr 17, 2024
@openshift-ci openshift-ci bot requested review from deads2k and neisw April 17, 2024 12:26
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin dgoodwin changed the title Server Side Views TRT-1574: Server Side Views Apr 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024

@dgoodwin: This pull request references TRT-1574 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Server now accepts a CLI param for --component-readiness-views views.yaml.

---
- name: main
 variant_options:
   group_by: ''
   platform: ''
   upgrade: ''
   arch: ''
   network: ''
   variant: ''
 exclude_options:
   exclude_platforms: ''
   exclude_arches: ''
   exclude_networks: ''
   exclude_upgrades: ''
   exclude_variants: ''
 advance_options:
   minimum_failure: 0
   confidence: 0
   pity_factor: 0
   ignore_missing: false
   ignore_disruption: false

Adds a new /api/component_readiness/views API call to list these views, and their params. This is intended for future use in the UI to list params, and allow a user to stop using the view but tweak it's settings to get their own custom URL.

/api/component_readiness now accepts a ?view=main param. If specified, all the params above should conflict with the fact you specified a view.

Thus far, start/end times are not part of the view, this will be up for discussion with the team. base and sample release are both still required, we may make base optional and assume to use sample-1 if sample is not GA yet, or sampleGA if it is.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor Author

/hold

We're working out how to use the variant registry in component readiness, which will impact the structure of these views. This can be reviewed but we'll hold off on merging until we get a final structure.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants