Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-6419 | feat: fetch OIDC thumbprint from CS #1949

Closed
wants to merge 1 commit into from
Closed

OCM-6419 | feat: fetch OIDC thumbprint from CS #1949

wants to merge 1 commit into from

Conversation

thomasmckay
Copy link

No description provided.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@openshift-ci openshift-ci bot requested review from den-rgb and oriAdler April 19, 2024 13:03
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thomasmckay
Once this PR has been reviewed and has the lgtm label, please assign pvasant for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thomasmckay thomasmckay force-pushed the 2534-thumbprint branch 2 times, most recently from fb47415 to 4fee338 Compare April 24, 2024 12:52
@thomasmckay thomasmckay force-pushed the 2534-thumbprint branch 2 times, most recently from dc9fcab to dcd16cb Compare May 8, 2024 14:04
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 8, 2024
robpblake
robpblake reviewed May 15, 2024
View reviewed changes
cmd/create/cluster/cmd.go Outdated
@@ -3225,7 +3225,16 @@ func run(cmd *cobra.Command, _ []string) {
if !output.HasFlag() || r.Reporter.IsTerminal() {
r.Reporter.Infof("Preparing to create OIDC Provider.")
}
oidcprovider.Cmd.Run(oidcprovider.Cmd, []string{clusterName, mode, ""})

cmd := (*oidcprovider.CreateOidcProvider).NewCommand()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasmckay I would simply call the run command on the cmd as before as that will take care of creating the runner and ensuring the args are bound the flags of the cmd.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making it much more difficult to create tests for but I'll keep trying

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@thomasmckay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 604d6f4 link true /test test
ci/prow/images-images 604d6f4 link true /test images-images
ci/prow/coverage 604d6f4 link true /test coverage
ci/prow/e2e-presubmits-images 604d6f4 link true /test e2e-presubmits-images
ci/prow/lint 604d6f4 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@robpblake
Copy link
Contributor

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Jun 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

@robpblake: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robpblake robpblake robpblake left review comments

@den-rgb den-rgb Awaiting requested review from den-rgb

@oriAdler oriAdler Awaiting requested review from oriAdler

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasmckay @robpblake @openshift-merge-robot