OSSM-4504 Add integration helm test run #51953
Conversation
|
This PR needs to be merged first: openshift-service-mesh/istio#15 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
|
To be able to run the rehearse over the new test we need merged first: openshift-service-mesh/istio#15 |
| # SRC_PATH does end with /. : the content of the source directory is copied into dest directory | ||
| oc cp ./. "${MAISTRA_NAMESPACE}"/"${MAISTRA_SC_POD}":/work/ | ||
| oc cp ${KUBECONFIG} ${MAISTRA_NAMESPACE}/${MAISTRA_SC_POD}:/work/ci-kubeconfig | ||
| oc cp `which oc` ${MAISTRA_NAMESPACE}/${MAISTRA_SC_POD}:/bin |
There was a problem hiding this comment.
we don't need to copy oc. It's already present in the builder image.
I realize that this cp command is present in all jobs. We can perform a cleanup in a follow up pr though, no rush.
There was a problem hiding this comment.
OK, I'll open a new one to delete this oc cp
|
/pj-rehearse ack |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
This past execution is a false positive: The test fails |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
removed
the
rehearsals-ack
|
New changes are detected. LGTM label has been removed. |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
PR not ready to be merged, stills fails some of the test that are being executed |
| cd /work && \ | ||
| entrypoint \ | ||
| prow/integ-suite-ocp.sh \ | ||
| helm 'TestAmbientInstall|TestAmbientInstallMultiNamespace'" |
There was a problem hiding this comment.
why skip those? Last time I checked, they were working fine on OCP.
There was a problem hiding this comment.
I was testing because they are failing in a previous run. Locally works everything but in our ci they are failing
There was a problem hiding this comment.
It's worth to investigate the failure
Skipping ambiet tests on helm suite Skip on helm suite upgrade test
|
I ran the test locally skipping the upgrade tests and passing the suite. Adding the skip of the upgrade test and running the test again to check the result |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Added the var |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Fix distroless variable declaration on helm integration test
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/rehearsals-ack |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pj-rehearse ack |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/lgtm |
|
@fjglira: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjglira, jwendell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
removed
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
|
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@fjglira: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Jira: https://issues.redhat.com/browse/OSSM-4504
Adding test job to run istio upstream integration helm test to the pre submit jobs in our fork