Updating CI build with AMD Roc images #51945
Conversation
|
@dibryant, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @dibryant. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dibryant, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
| - context_dir: amd/ubi8-python-3.8 | ||
| dockerfile_path: Dockerfile | ||
| from: base-ubi8-python-3.8 | ||
| to: amd-ubi8-python-3.8 | ||
| - context_dir: jupyter/minimal/ubi8-python-3.8 | ||
| dockerfile_path: Dockerfile | ||
| from: amd-ubi8-python-3.8 | ||
| to: amd-jupyter-minimal-ubi8-python-3.8 |
There was a problem hiding this comment.
can drop the ubi8, as we would only be building for ubi9 or c9s.
| - as: notebook-amd-jupyter-minimal-ubi8-python-3-8-image-mirror | ||
| postsubmit: true | ||
| steps: | ||
| dependencies: | ||
| SOURCE_IMAGE_REF: amd-jupyter-minimal-ubi8-python-3.8 | ||
| env: | ||
| IMAGE_REPO: workbench-images | ||
| IMAGE_TAG: YearIndex | ||
| RELEASE_VERSION: amd-jupyter-minimal-ubi8-python-3.8 | ||
| workflow: opendatahub-io-ci-image-mirror | ||
| - as: notebook-amd-jupyter-minimal-ubi8-python-3-8-pr-image-mirror | ||
| run_if_changed: (amd\/ubi8-python-3.8\/*)|(base\/ubi8-python-3.8\/*)|(jupyter\/minimal\/ubi8-python-3.8\/*) | ||
| steps: | ||
| dependencies: | ||
| SOURCE_IMAGE_REF: amd-jupyter-minimal-ubi8-python-3.8 | ||
| env: | ||
| IMAGE_REPO: workbench-images | ||
| IMAGE_TAG: YearIndex | ||
| RELEASE_VERSION: amd-jupyter-minimal-ubi8-python-3.8 | ||
| workflow: opendatahub-io-ci-image-mirror | ||
| - as: notebook-base-ubi9-python-3-9-image-mirror | ||
| postsubmit: true | ||
| steps: | ||
| dependencies: | ||
| SOURCE_IMAGE_REF: base-ubi9-python-3.9 | ||
| env: | ||
| IMAGE_REPO: workbench-images | ||
| IMAGE_TAG: YearIndex | ||
| RELEASE_VERSION: base-ubi9-python-3.9 | ||
| workflow: opendatahub-io-ci-image-mirror |
There was a problem hiding this comment.
can drop the ubi8, as we would only be building for ubi9 or c9s.
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
Hey Diamond, to resolve the issue you need to run If you press on details button on the failed job, it redirects you on the logs page so you may see what it suggest you to fix the test. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/51945/pull-ci-openshift-release-master-generated-config/1791465803057467392 |
| @@ -169,6 +177,10 @@ images: | |||
| dockerfile_path: Dockerfile | |||
| from: cuda-c9s-python-3.9 | |||
| to: cuda-rstudio-c9s-python-3.9 | |||
| - context_dir: amd/c9s-python-3.9 | |||
There was a problem hiding this comment.
Shall we build also the minimal version amd-jupyter-minimal-c9s-python-3.9?
dibryant
changed the title
| - context_dir: amd/ubi9-python-3.9 | ||
| dockerfile_path: Dockerfile | ||
| from: base-ubi9-python-3.9 | ||
| to: amd-ubi9-python-3.9 | ||
| - context_dir: jupyter/minimal/ubi9-python-3.9 | ||
| dockerfile_path: Dockerfile | ||
| from: amd-ubi9-python-3.9 | ||
| to: amd-jupyter-minimal-ubi9-python-3.9 |
There was a problem hiding this comment.
As we are not building UBI based image in the first interaction, we can remove these.
| - context_dir: amd/c9s-python-3.9 | ||
| dockerfile_path: Dockerfile | ||
| from: base-c9s-python-3.9 | ||
| to: amd-c9s-python-3.9 |
There was a problem hiding this comment.
| to: amd-c9s-python-3.9 | |
| to: amd-c9s-python-3.9 | |
| - context_dir: jupyter/minimal/ubi9-python-3.9 | |
| dockerfile_path: Dockerfile | |
| from: amd-c9s-python-3.9 | |
| to: amd-jupyter-minimal-c9s-python-3.9 |
based on the suggestion, we could actually us the minimal for testing
dibryant
force-pushed
the
amd
branch
2 times, most recently
from
a149bb3
to
55443dc
Compare
|
[REHEARSALNOTIFIER]
A total of 47 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibryant, harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| dockerfile_path: Dockerfile | ||
| from: base-c9s-python-3.9 | ||
| to: amd-c9s-python-3.9 | ||
| - context_dir: jupyter/minimal/ubi9-python-3.9 |
There was a problem hiding this comment.
I'm not sure if this will be successful, but we can give it a shot.
|
/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-amd-c9s-python-3-9-pr-image-mirror |
|
@atheo89: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@atheo89: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror |
|
@atheo89: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
As this is merged: opendatahub-io/notebooks#507 |
|
/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-amd-c9s-python-3-9-pr-image-mirror |
|
@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror |
|
@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
The rehearse seems to be working: /pj-rehearse ack |
|
@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@dibryant: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
FIxes for https://issues.redhat.com/browse/RHOAIENG-4608
Updated the CI build to include AMD Roc images