-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[release-4.20] CNTRLPLANE-945: improve logging, add startup probe to Keycloak Deployment #30204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Conversation
so that we can hook directly into the Ginkgo output controls as opposed to relying on standard library printing behavior Signed-off-by: Bryce Palmer <[email protected]>
so that liveness and readiness probes don't fail prematurely, causing Kubelet to restart the Keycloak Pod before it has finished starting up. Signed-off-by: Bryce Palmer <[email protected]>
by re-using the existing WaitForOperatorsToSettle utility function. This change ensures that we wait for all cluster-operators to have settled prior to continuing any testing behaviors. Signed-off-by: Bryce Palmer <[email protected]>
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNTRLPLANE-945 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #30184
/assign everettraven