[WIP] Check for control-plane operator in hypershift for oauth test #30200
Conversation
In HyperShift env, cluster-authentication-operator doesn't run in management cluster. Instead, control-plane operator will handle authenication operations. Signed-off-by: Vu Dinh <[email protected]>
dinhxuanvu
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance-serial |
|
@dinhxuanvu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74f7ed50-8803-11f0-8764-482860b01723-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| } | ||
| } | ||
| } | ||
| o.Expect(isCPODeployment).To(o.Equal(true), "control-plane-operator deployment exists") |
There was a problem hiding this comment.
Is checking existence of the CPO sufficient here?
It looks like on standalone we are intentionally looking for a signal that the cluster-authentication-operator is no longer progressing (presumably meaning the OAuth server is up and ready to accept requests). Is there an equivalent status condition or something we could use to identify that everything auth related is up and ready for connections?
There was a problem hiding this comment.
I'm simply testing out the CPO check to see if it works. From the initial look, this test may not even be compatible with HyperShift and may need to be skipped in HCP case. There is already a check in the code to skip on ExternalTopologyMode which is the case for HCP given CAO component doesn't run on management cluster. The topology check is placed after CAO availability check and that's why the test fails. That check should have been placed before CAO check.
|
@dinhxuanvu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In HyperShift env, cluster-authentication-operator doesn't run in management cluster. Instead, control-plane operator will handle authenication operations.