TRT-2068: additional defaults for MicroShift #29904
Conversation
|
@smg247: This pull request references TRT-2068 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
stbenjam
left a comment
stbenjam
left a comment
There was a problem hiding this comment.
Should we be setting other fields for Microshift?
time="2025-06-09T19:40:57Z" level=info msg="Adding the following applicable flags to the list command: --platform=skeleton --network=OVNKubernetes --network-stack= --external-connectivity=Direct" binary=k8s-tests-ext
We're leaving an empty network stack which I think is a mistake. I'm also not sure --platform=skeleton is what we really should be sending, can we identify the platform any other way?
That's a good question, no other fields seem to be necessary for the currently defined rules, but it is possible that may be the case in the future. I can ask in their forum. |
We are currently using the static manifests technique, so everything that we hardcode here is safe to assume that wont change and we can include other fields too. |
smg247
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smg247, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/skip |
|
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: c79bb50
|
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-serial-2of2 |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-serial-2of2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tide is being a little overzealous in retesting. Also, these changes only affect microshift. /skip |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-fips |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-fips DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
5 participants
No description provided.