Skip to content

[release-4.19] OCPBUGS-57217: Stabilize custom MCP cleanup on MCN tests #29902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] OCPBUGS-57217: Stabilize custom MCP cleanup on MCN tests #29902

wants to merge 1 commit into from

Conversation

isabella-janssen
Copy link
Member

This is a manual cherrypick of #29874 since the automated cherrypick failed.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
@isabella-janssen isabella-janssen marked this pull request as ready for review June 9, 2025 16:51
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 9, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-57217, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56037 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56037 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherrypick of #29874 since the automated cherrypick failed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 9, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/685f97c0-4701-11f0-9350-2b17cb82533d-0

@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7b3fe30-478c-11f0-91cf-ce400de7b64a-0

@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2025

@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b9826ba0-486e-11f0-9e66-140dccb941cd-0

dkhater-redhat
dkhater-redhat approved these changes Jun 13, 2025
View reviewed changes
Copy link

@dkhater-redhat dkhater-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dkhater-redhat
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 827e2ac and 2 for PR HEAD c973171 in total

@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 827e2ac and 2 for PR HEAD c973171 in total

@isabella-janssen
Copy link
Member Author

/retest-required

1 similar comment
@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/retest-required

1 similar comment
@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 827e2ac and 2 for PR HEAD c973171 in total

@isabella-janssen
Copy link
Member Author

/retest-required

1 similar comment
@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 827e2ac and 2 for PR HEAD c973171 in total

@isabella-janssen
Copy link
Member Author

/retest-required

5 similar comments
@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 827e2ac and 2 for PR HEAD c973171 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade c973171 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-techpreview c973171 link false /test e2e-metal-ipi-ovn-dualstack-bgp-techpreview
ci/prow/e2e-gcp-csi c973171 link false /test e2e-gcp-csi
ci/prow/e2e-openstack-ovn c973171 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-rt-upgrade c973171 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout c973171 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-gcp-ovn c973171 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade c973171 link true /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sergiordlr
Copy link

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@sergiordlr: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhater-redhat dkhater-redhat dkhater-redhat approved these changes

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

Assignees

@dkhater-redhat dkhater-redhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isabella-janssen @openshift-ci-robot @dkhater-redhat @sergiordlr