New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-812: feat: add tests for cpu limits on workload partitioning #28752
OCPEDGE-812: feat: add tests for cpu limits on workload partitioning #28752
Conversation
@eggfoobar: This pull request references OCPEDGE-812 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks reasonnable
workload partitioning now supports cpu limits in resources added a new test and updated existing ones to validate it. added test to check annotations and resources have been altered updated existing crio check to also validate cpu limits via quota settings Signed-off-by: ehila <[email protected]>
0f264dd
to
b4b1b12
Compare
/retest-required |
Job Failure Risk Analysis for sha: b4b1b12
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e753fc9
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202405072356.p0.ge753fc9.assembly.stream.el9 for distgit openshift-enterprise-tests. |
workload partitioning now supports cpu limits in resources added a new test and updated existing ones to validate it.
added test to check annotations and resources have been altered updated existing crio check to also validate cpu limits via quota settings