Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-812: feat: add tests for cpu limits on workload partitioning #28752

Merged

Conversation

eggfoobar
Copy link
Contributor

workload partitioning now supports cpu limits in resources added a new test and updated existing ones to validate it.

added test to check annotations and resources have been altered updated existing crio check to also validate cpu limits via quota settings

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 27, 2024

@eggfoobar: This pull request references OCPEDGE-812 which is a valid jira issue.

In response to this:

workload partitioning now supports cpu limits in resources added a new test and updated existing ones to validate it.

added test to check annotations and resources have been altered updated existing crio check to also validate cpu limits via quota settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from MarSik and omertuc April 27, 2024 08:40
@eggfoobar
Copy link
Contributor Author

/retest-required

Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks reasonnable

test/extended/cpu_partitioning/crio.go Outdated Show resolved Hide resolved
test/extended/cpu_partitioning/managed.go Outdated Show resolved Hide resolved
test/extended/cpu_partitioning/utils.go Outdated Show resolved Hide resolved
workload partitioning now supports cpu limits in resources added a new test and updated existing ones to validate it.

added test to check annotations and resources have been altered
updated existing crio check to also validate cpu limits via quota settings

Signed-off-by: ehila <[email protected]>
@eggfoobar eggfoobar force-pushed the wrk-prt-support-cpu-limits branch from 0f264dd to b4b1b12 Compare May 1, 2024 04:31
@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: b4b1b12

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (12) are below the historical average (1183): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@rphillips
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15c3521 and 2 for PR HEAD b4b1b12 in total

Copy link
Contributor

openshift-ci bot commented May 6, 2024

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial b4b1b12 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node b4b1b12 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade b4b1b12 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 75f7e06 and 1 for PR HEAD b4b1b12 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 97cb6b3 and 0 for PR HEAD b4b1b12 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e753fc9 into openshift:master May 7, 2024
20 of 23 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202405072356.p0.ge753fc9.assembly.stream.el9 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants