e2e test taking ownership of a field #28740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
deads2k
commented
Apr 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
deads2k
commented
Apr 24, 2024
| Force: true, | ||
| }) | ||
| postBytes, _ = json.Marshal(postApply.Object) | ||
| framework.Logf("after trying to replace the field\n%v", string(postBytes)) |
There was a problem hiding this comment.
{
"apiVersion": "testing.openshift.io/v1",
"kind": "SSAWithSet",
"metadata": {
"creationTimestamp": "2024-04-24T21:14:18Z",
"generation": 2,
"managedFields": [
{
"apiVersion": "testing.openshift.io/v1",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:spec": {
"f:setList": {
"v:\"first\"": {},
"v:\"second\"": {}
},
"f:unrelatedField": {}
}
},
"manager": "creator",
"operation": "Apply",
"time": "2024-04-24T21:14:18Z"
},
{
"apiVersion": "testing.openshift.io/v1",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:spec": {
"f:setList": {
"v:\"apple\"": {},
"v:\"banana\"": {}
}
}
},
"manager": "new-owner",
"operation": "Apply",
"time": "2024-04-24T21:14:18Z"
}
],
"name": "foo",
"resourceVersion": "65295",
"uid": "27acfc2e-7452-4722-b043-5e1a86cab35f"
},
"spec": {
"setList": [
"first",
"second",
"apple",
"banana"
],
"unrelatedField": "keep-original-owner"
}
}
|
alright, the combination of shared ownership and set sharing and ownership transfer means that there is no clear way to transfer ownership of set lists. We'll need to decide whether to
|
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demonstrate how to take ownership of a set-list.
/hold