Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32523: [release-4.15] e2e-chart: copy label contents to clipboard when segment is clicked #28730

Open
wants to merge 2 commits into
base: release-4.15
Choose a base branch
from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Apr 22, 2024

Cherrypick of #27965 on release-4.15

This wraps tooltips in e2e chart to make sure that tooltips don't overflow X when a long label is used.
@vrutkovs
Copy link
Member Author

/jira cherrypick OCPBUGS-32484

@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-32484 has been cloned as Jira Issue OCPBUGS-32523. Will retitle bug to link to clone.
/retitle OCPBUGS-32523: e2e-chart: copy label contents to clipboard when segment is clicked

In response to this:

/jira cherrypick OCPBUGS-32484

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title e2e-chart: copy label contents to clipboard when segment is clicked OCPBUGS-32523: e2e-chart: copy label contents to clipboard when segment is clicked Apr 22, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-32523, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-32484 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mfojtik and sjenning April 22, 2024 10:42
@vrutkovs vrutkovs changed the title OCPBUGS-32523: e2e-chart: copy label contents to clipboard when segment is clicked OCPBUGS-32523: [release-4.15] e2e-chart: copy label contents to clipboard when segment is clicked Apr 22, 2024
@sanchezl
Copy link
Contributor

/retest

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl, vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial ad9a5a8 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-etcd-recovery ad9a5a8 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-upgrade ad9a5a8 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants