HOSTEDCP-1466: test/ginkgo: allow many external binaries #28720
Conversation
Not only do we ultimately need to support external binaries from more than one image in the payload, we also need to support repositories that use `go test` for their end-to-end tests along with the old-school Ginkgo approach. Signed-off-by: Steve Kuznetsov <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@stevekuznetsov: This pull request references HOSTEDCP-1466 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| // /tests/ | ||
| // ├── a | ||
| // │ ├── b | ||
| // │ ├── b.package.txt |
There was a problem hiding this comment.
n.b. the Go module being tested is information that is lost during go test -c ... so we need to record it in a side-channel and consume that here.
| return TestFailed, []byte(fmt.Errorf("failed unmarshalling test event from output %s: %w", string(testOutputBytes), err).Error()) | ||
| } | ||
|
|
||
| // TODO: lots of events are possible here, and it's possible more than one test runs, etc |
There was a problem hiding this comment.
Open to suggestions here, the execution model does not accurately map here.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stevekuznetsov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Not only do we ultimately need to support external binaries from more than one image in the payload, we also need to support repositories that use
go testfor their end-to-end tests along with the old-school Ginkgo approach./assign @soltysh
/cc @deads2k