Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDN-4783: Add e2e tests for NetworkDiagnosticsConfig featuregate #28719

Merged
merged 2 commits into from May 8, 2024
Merged

SDN-4783: Add e2e tests for NetworkDiagnosticsConfig featuregate #28719

merged 2 commits into from May 8, 2024

Conversation

kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Apr 17, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2024 •
edited by openshift-ci bot

@kyrtapz: This pull request references SDN-4783 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This is blocked by openshift/cluster-network-operator#2339

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 17, 2024
ricky-rav
ricky-rav reviewed Apr 18, 2024
View reviewed changes
Copy link

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I left a few questions.

test/extended/networking/network_diagnostics.go Show resolved Hide resolved
test/extended/networking/network_diagnostics.go Show resolved Hide resolved
test/extended/networking/network_diagnostics.go Show resolved Hide resolved
@ricky-rav
Copy link

/lgtm
Thanks, @kyrtapz!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@trozet
Copy link
Contributor

trozet commented Apr 23, 2024

/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@kyrtapz kyrtapz marked this pull request as ready for review April 24, 2024 09:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024
@openshift-ci openshift-ci bot requested review from deads2k and knobunc April 24, 2024 09:21
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 24, 2024

/test images

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 24, 2024

CI seems to be back
/retest

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 24, 2024

/test images

1 similar comment
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 24, 2024

/test images

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 24, 2024

@dgoodwin are you ok with the cliet-go bump? It looks like the bot needs your blessing

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 25, 2024

/retest

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 25, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@kyrtapz: The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-baremetalds-kubevirt
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-local-gateway
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Apr 25, 2024

/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial

@dgoodwin
Copy link
Contributor

/approve

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 7, 2024

Network diagnostics tests passed, the unrelated failure is already tracked

@kyrtapz kyrtapz mentioned this pull request May 7, 2024
Merged
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 6d1ff92

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial Low
[sig-arch] events should not repeat pathologically
This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days.

Open Bugs
CSO generates excessive progressing condition events
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager"
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
"k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

@ricky-rav
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@dgoodwin
Copy link
Contributor

dgoodwin commented May 7, 2024

/override ci/prow/e2e-gcp-ovn-builds

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-gcp-ovn-builds

In response to this:

/override ci/prow/e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 7, 2024

/test e2e-metal-ipi-ovn-ipv6

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 7, 2024

/retest-required

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 6d1ff92

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial Low
[sig-arch] events should not repeat pathologically
This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days.

Open Bugs
CSO generates excessive progressing condition events
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager"
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
"k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e753fc9 and 2 for PR HEAD 6d1ff92 in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 6d1ff92

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial Low
[sig-arch] events should not repeat pathologically
This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days.

Open Bugs
CSO generates excessive progressing condition events
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager"
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
"k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

1 similar comment
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 6d1ff92

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial Low
[sig-arch] events should not repeat pathologically
This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days.

Open Bugs
CSO generates excessive progressing condition events
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager"
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated.
"k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 574269c and 1 for PR HEAD 6d1ff92 in total

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 8, 2024

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 8, 2024

Had to re-vendor after rebasing to master.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 8, 2024

/test e2e-gcp-ovn-techpreview-serial

@jcaamano
Copy link
Contributor

jcaamano commented May 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jcaamano, kyrtapz, ricky-rav, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 8, 2024

/test e2e-gcp-ovn-builds

@kyrtapz
Copy link
Contributor Author

kyrtapz commented May 8, 2024

/tide refresh

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview-serial 432f8e5 link false /test e2e-gcp-ovn-techpreview-serial
ci/prow/e2e-openstack-ovn 432f8e5 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 432f8e5 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 432f8e5 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-sdn 432f8e5 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 432f8e5 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9d46920 into openshift:master May 8, 2024
18 of 24 checks passed
@kyrtapz kyrtapz mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricky-rav ricky-rav ricky-rav left review comments

@trozet trozet trozet approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@ricky-rav ricky-rav

@jcaamano jcaamano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kyrtapz @openshift-ci-robot @ricky-rav @trozet @dgoodwin @openshift-trt-bot @jcaamano @openshift-merge-robot