Add new test for commatrix in extended/networking #28706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for the 'comMatrix' (Communication Matrix) library. This library generates a description of the ports to which the cluster listens for ingress traffic. The test currently validates that the Communication Matrix generated by the library covers all the open ports on the nodes. It does so by comparing the output of the 'ss' command on the nodes. Note: the test also manully creates endpointslices that represent host services that don't have one natively. Some of them are static and known ports. See more here: https://github.com/openshift/enhancements/blob/master/dev-guide/host-port-registry.md Others are host services with random ports that we create the endpointslices from the given "ss" output for that specific service (rpc, and crio, ovnkube). The test create the relevant artifacts under the "commatrix" dir. the artifacts that can be found are: 1. The communicatiom matrix. 2. The ss entries we compare against. 3. Diff of 1, and 2. 4. Diff of 2, and 1. 5. Raw tcp 'ss' output on nodes. 6. Raw udp 'ss' output on nodes. Signed-off-by: Lior Noy <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sabinaaledort The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Job Failure Risk Analysis for sha: f1a71ac
|
sabinaaledort
force-pushed
the
add-commatrix-tests
branch
from
f1a71ac
to
aefb97e
Compare
|
Job Failure Risk Analysis for sha: aefb97e
|
sabinaaledort
force-pushed
the
add-commatrix-tests
branch
4 times, most recently
from
00573b7
to
0718a61
Compare
|
Job Failure Risk Analysis for sha: 0718a61
|
sabinaaledort
force-pushed
the
add-commatrix-tests
branch
from
0718a61
to
6023e4b
Compare
|
Job Failure Risk Analysis for sha: 6023e4b
|
sabinaaledort
force-pushed
the
add-commatrix-tests
branch
from
6023e4b
to
6b3e35b
Compare
|
Job Failure Risk Analysis for sha: 6b3e35b
|
sabinaaledort
force-pushed
the
add-commatrix-tests
branch
from
6b3e35b
to
c56ce16
Compare
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closed
|
@sabinaaledort: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: c56ce16
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commatrix library generates a description of the ports to which the
cluster listens for ingress traffic.
The test currently validates that the Communication Matrix
generated by the library covers all the open ports on the nodes.
It does so by comparing the output of the 'ss' command on the nodes.
The test create the relevant artifacts under the "commatrix"
dir. the artifacts that can be found are: