-
Notifications
You must be signed in to change notification settings - Fork 209
NO-ISSUE: add RestartSec=10s for systemd service #4978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance5890 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @pacevedom |
@lance5890: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hey @lance5890, thanks for your contribution. Could you explain how increasing time between restarts will help you? /label ok-to-test |
@pmtk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
We deployed MicroShift on a host with insufficient performance. During startup, we found that the network was not fully configured before the systemd service started, which caused MicroShift to fail to start. After failing more than five times, it stopped attempting to start. The issue was resolved after we manually adjusted the RestartSec=10s. |
/retest-required |
21a2dbd
to
7f7c30c
Compare
Signed-off-by: lan.tian <[email protected]>
7f7c30c
to
2449320
Compare
I noticed you've taken steps to address the problem with StartLimitIntervalSec. I would suggest instead that you use a systemd drop-in to configure required settings to match your environment. |
directly extending the RestartSec parameter to 10s might be a bit risky, but I still suggest starting by modifying this value to 1s (compared to the default of 100ms) would resolve most issues |
@lance5890: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Which issue(s) this PR addresses:
As the default RestartSec is 100ms,The microshift may not startup in default StartLimitBurst(5 times) ; we should expand the systemd RestartSec to 10s,just like the etcd serivce does as follows:
microshift/ansible/roles/install-microshift/files/etcd.service
Line 20 in 032d259