Skip to content

[release-4.20] OCPBUGS-76921: Prevent unnecessary systemd unit disable#5664

Draft
isabella-janssen wants to merge 1 commit intoopenshift:release-4.20from
isabella-janssen:ocpbugs-58023-420
Draft

[release-4.20] OCPBUGS-76921: Prevent unnecessary systemd unit disable#5664
isabella-janssen wants to merge 1 commit intoopenshift:release-4.20from
isabella-janssen:ocpbugs-58023-420

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Feb 13, 2026

- What I did
This is a manual cherrypick of #5648.

- How to verify it
See #5148 (comment) and #5612 (comment) for verification details.

- Description for the changelog
OCPBUGS-76921: Prevent unnecessary systemd unit disable

update: only write added or updated systemd units unless forcefile exists then rewrite all systemd units
on_disk_validation: check if systemd units in config enabled correctly
tests: update MCN condition transition test to account for quick transitions through 'Unknown' state
(cherry picked from commit 4512ec4)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2026
@isabella-janssen
Copy link
Member Author

/jira cherrypick OCPBUGS-73805

@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: Jira Issue OCPBUGS-73805 has been cloned as Jira Issue OCPBUGS-76921. Will retitle bug to link to clone.
/retitle OCPBUGS-76921: Prevent unnecessary systemd unit disable

Details

In response to this:

/jira cherrypick OCPBUGS-73805

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Prevent unnecessary systemd unit disable OCPBUGS-76921: Prevent unnecessary systemd unit disable Feb 13, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 13, 2026
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-76921, which is invalid:

  • expected dependent Jira Issue OCPBUGS-73805 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
This is a manual cherrypick of #5648.

- How to verify it
See #5148 (comment) and #5612 (comment) for verification details.

- Description for the changelog
OCPBUGS-: Prevent unnecessary systemd unit disable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026
@isabella-janssen isabella-janssen changed the title OCPBUGS-76921: Prevent unnecessary systemd unit disable [release-4.20] OCPBUGS-76921: Prevent unnecessary systemd unit disable Feb 13, 2026
@isabella-janssen
Copy link
Member Author

/test verify

@isabella-janssen
Copy link
Member Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit efe09d1 link true /test unit
ci/prow/e2e-gcp-op-ocl efe09d1 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants