OCPBUGS-76353: Ensure dbus calls are sync#5643
OCPBUGS-76353: Ensure dbus calls are sync#5643pablintino wants to merge 2 commits intoopenshift:mainfrom
Conversation
Replace direct systemctl exec calls with a systemd abstraction layer that uses the coreos/go-systemd library. The new SystemdManager factory pattern improves performance, maintainability, and testing by introducing easily mockable interfaces and enabling connection reuse. There are two ways of using the new interfaces: - DoConnection() for single operations with automatic cleanup - NewConnection() for batching multiple operations on one connection Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
Pass a completion channel to StopUnit, StartUnit, RestartUnit, ReloadUnit, and TryRestartUnit D-Bus calls and wait for the job result, matching the synchronous behavior of the systemctl calls they replaced. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
openshift-ci-robot
added
jira/valid-reference
|
@pablintino: This pull request references Jira Issue OCPBUGS-76353, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pablintino: This pull request references Jira Issue OCPBUGS-76353, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
RishabhSaini,
dkhater-redhat and
wangke19
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-ovn-day1-ocl |
|
@pablintino: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/81278e00-0666-11f1-9969-5c084223b921-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade |
|
@pablintino: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-upgrade-fips 10 |
|
@pablintino: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade |
|
@pablintino: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ddcaef30-0684-11f1-8fbc-eedc56cc70bd-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-upgrade-fips 10 |
|
@pablintino: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dcbbaed0-0694-11f1-83b9-07606fc0937e-0 |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade |
|
@pablintino: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/740626d0-0695-11f1-8387-4b16e374b542-0 |
|
/test okd-scos-images |
|
@pablintino: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Closes: #OCPBUGS-76353
- What I did
Pass a completion channel to StopUnit, StartUnit, RestartUnit, ReloadUnit, and TryRestartUnit D-Bus calls and wait for the job result, matching the synchronous behavior of the systemctl calls they replaced.
- How to verify it
The following payload should be enough to verify the change
- Description for the changelog
Pass a completion channel to dbus calls and wait for the job result, matching the synchronous behavior of the systemctl calls they replaced.