OCPBUGS-63699: Remove MCD liveness probe

[pablintino]

Closes: #OCPBUGS-63699

- What I did

The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.

- How to verify it

- Description for the changelog

Remove unused MCD liveness probe to avoid mid-update restarts.

[openshift-ci-robot]

@pablintino: This pull request references Jira Issue OCPBUGS-63699, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: #OCPBUGS-63699

- What I did

The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.

- How to verify it

- Description for the changelog

Remove unused MCD liveness probe to avoid mid-update restarts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pablintino]

/jira refresh

[openshift-ci-robot]

@pablintino: This pull request references Jira Issue OCPBUGS-63699, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[umohnani8]

/lgtm
/verified bypass

[djoshy]

/hold

Sorry if this was discussed already, does this not need pre-merge?

[djoshy]

Changes look sane to me otherwise 😄

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, pablintino, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy,pablintino,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pablintino]

/verified by @ptalgulk01 and @sergiordlr

[pablintino]

/unhold

[openshift-ci-robot]

@pablintino: This PR has been marked as verified by @ptalgulk01 and @sergiordlr.

Details

In response to this:

/verified by @ptalgulk01 and @sergiordlr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@pablintino: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@pablintino: Jira Issue Verification Checks: Jira Issue OCPBUGS-63699
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63699 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Closes: #OCPBUGS-63699

- What I did

The current liveness probe implementation triggers a container restart if long-running operations (like rpm-ostree rebases) exceed the timeout.
This causes the MCD to be killed mid-transaction, leading to inconsistent on-disk state and "content mismatch" errors.

Since the MCD does not serve external API traffic and that a restart won't solve most of the failures of a slow or wrong update, removing the probe is the most simple way of preventing inconsistencies till a proper probe is implemented.

- How to verify it

- Description for the changelog

Remove unused MCD liveness probe to avoid mid-update restarts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pablintino]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@pablintino: new pull request created: #5651

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.