Skip to content

CORENET-6738: Remove lingering references to openshift-sdn#5591

Open
danwinship wants to merge 1 commit intoopenshift:mainfrom
danwinship:no-openshift-sdn
Open

CORENET-6738: Remove lingering references to openshift-sdn#5591
danwinship wants to merge 1 commit intoopenshift:mainfrom
danwinship:no-openshift-sdn

Conversation

@danwinship
Copy link
Contributor

openshift-sdn was removed in 4.17 so there's no reason to keep code for deploying it around any more.

configure-ovs.sh only gets installed for ovn-k now, so I removed the internal network-type checks. mtu-migration should only get called for ovn-k (based on checks in CNO), but I left the initial check there and just removed the internal ovn-k/openshift-sdn checks.

(some files best viewed with "don't show whitespace changes")

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2026

@danwinship: This pull request references CORENET-6738 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

openshift-sdn was removed in 4.17 so there's no reason to keep code for deploying it around any more.

configure-ovs.sh only gets installed for ovn-k now, so I removed the internal network-type checks. mtu-migration should only get called for ovn-k (based on checks in CNO), but I left the initial check there and just removed the internal ovn-k/openshift-sdn checks.

(some files best viewed with "don't show whitespace changes")

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danwinship
Copy link
Contributor Author

/retest-required

Copy link
Contributor

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@danwinship
Copy link
Contributor Author

/assign @umohnani8

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2026
@yuqi-zhang
Copy link
Contributor

/approve

@yuqi-zhang
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, ricky-rav, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2026

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade cd13fea link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-hypershift cd13fea link true /test e2e-hypershift
ci/prow/e2e-aws-ovn cd13fea link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants