Skip to content

MCO-2036: Enable boot image updates by default for vsphere and Azure#5583

Open
djoshy wants to merge 2 commits intoopenshift:mainfrom
djoshy:azure-vsphere-opt-out
Open

MCO-2036: Enable boot image updates by default for vsphere and Azure#5583
djoshy wants to merge 2 commits intoopenshift:mainfrom
djoshy:azure-vsphere-opt-out

Conversation

@djoshy
Copy link
Contributor

@djoshy djoshy commented Jan 20, 2026

- What I did
This PR enables boot image updates by default for Azure and vsphere, and adjusts any test behavior to account for this:

  • The boot image tests requires the skew feature to be disabled as it needs to cycle through all boot image configuration modes.
  • The skew enforcement test for Automatic mode can now run on these platforms as boot image updates are enabled by default.

- How to verify it
An installation on this PR should show the managedBootImageStatus MachineConfiguration object set to All for MAPI MachineSet objects:

  spec:
    logLevel: Normal
    managementState: Managed
    operatorLogLevel: Normal
  status:
 ...
    managedBootImagesStatus:
      machineManagers:
      - apiGroup: machine.openshift.io
        resource: machinesets
        selection:
          mode: All

As a result, boot image updates should took place automatically without a spec.managedBootImages field defined. Any edits to the boot images defined in the MachineSet will be stomped back to the reference defined by the coreos-bootimages configmap.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026

@djoshy: This pull request references MCO-2036 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
This PR enables boot image updates by default for Azure and vsphere, and adjusts any test behavior to account for this.

- How to verify it
Boot image updates should take place by default on these platforms when the user hasn't provided an opinion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026

@djoshy: This pull request references MCO-2036 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
This PR enables boot image updates by default for Azure and vsphere, and adjusts any test behavior to account for this.

- How to verify it
An installation on this PR should show the managedBootImageStatus MachineConfiguration object set to All for MAPI MachineSet objects:

 spec:
   logLevel: Normal
   managementState: Managed
   operatorLogLevel: Normal
 status:
...
   managedBootImagesStatus:
     machineManagers:
     - apiGroup: machine.openshift.io
       resource: machinesets
       selection:
         mode: All

As a result, boot image updates should took place automatically without a spec.managedBootImages field defined. Any edits to the boot images defined in the MachineSet will be stomped back to the reference defined by the coreos-bootimages configmap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor Author

djoshy commented Jan 20, 2026

/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fcd17e20-f636-11f0-9b60-3c66bfc66382-0

@djoshy
Copy link
Contributor Author

djoshy commented Jan 22, 2026

/hold

we also need to reconcile the disruptive boot image tests when we enable these platforms by default, similar to openshift/origin#30712

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2026
@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 #5583

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b688eb0-f874-11f0-804b-b09532f7bee8-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: This PR was included in a payload test run from #5583
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b688eb0-f874-11f0-804b-b09532f7bee8-0

@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: aborted 1 active payload job(s) for pull request #5583

@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 #5428

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b1a46080-f874-11f0-9b01-9954da0d5f2e-0

@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2 #5428

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b51b37c0-f874-11f0-8ef4-e8cbff9ca2ef-0

@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 #5428

@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2 #5428

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c0bf6970-f874-11f0-9e49-5df462546e97-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c3f7b110-f874-11f0-9f8c-7baaab3813ed-0

@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: no active payload jobs found to abort for pull request #5583

@djoshy djoshy force-pushed the azure-vsphere-opt-out branch from 4812e55 to 64a18b3 Compare January 23, 2026 18:07
@djoshy
Copy link
Contributor Author

djoshy commented Jan 23, 2026

/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cd9efc20-f886-11f0-8155-2ad31ce2de83-0

@djoshy djoshy force-pushed the azure-vsphere-opt-out branch from 64a18b3 to 1a3bcbf Compare January 26, 2026 14:11
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2026
@pablintino
Copy link
Contributor

/lgtm

@sergiordlr
Copy link
Contributor

Vsphere:

This is the default configuration now:

$ oc get machineconfiguration -oyaml
...
    managedBootImagesStatus:
      machineManagers:
      - apiGroup: machine.openshift.io
        resource: machinesets
        selection:
          mode: All

All e2e bootimages update test cases passed. Including the default test cases which are not skipped anymore in vsphere and azure.

started: (0/1/11) "[sig-mco] MCO Bootimages Author:sregidor-NonHyperShiftHOST-NonPreRelease-Medium-81403-[P1][OnCLayer] In BootImages Machineset should update by default [Disruptive] [Serial]"
passed: (1m24s) 2026-02-13T11:51:36 "[sig-mco] MCO Bootimages Author:sregidor-NonHyperShiftHOST-NonPreRelease-Medium-81403-[P1][OnCLayer] In BootImages Machineset should update by default [Disruptive] [Serial]"


started: (0/5/11) "[sig-mco] MCO Bootimages Author:ptalgulk-NonHyperShiftHOST-NonPreRelease-High-81395-[P1] Verify in boot-image by default update is opt-in. [Disruptive] [Serial]"
passed: (53.2s) 2026-02-13T12:10:40 "[sig-mco] MCO Bootimages Author:ptalgulk-NonHyperShiftHOST-NonPreRelease-High-81395-[P1] Verify in boot-image by default update is opt-in. [Disruptive] [Serial]"

Azure:

This is the default configuration now:

$ oc get machineconfiguration -oyaml
...
    managedBootImagesStatus:
      machineManagers:
      - apiGroup: machine.openshift.io
        resource: machinesets
        selection:
          mode: All
      - apiGroup: machine.openshift.io
        resource: controlplanemachinesets
        selection:
          mode: None

All e2e bootimages update and controlplanemachineset test cases passed. Including the default test cases which are not skipped anymore in vsphere and azure.

started: (0/3/11) "[sig-mco] MCO Bootimages Author:sregidor-NonHyperShiftHOST-NonPreRelease-Medium-81403-[P1][OnCLayer] In BootImages Machineset should update by default [Disruptive] [Serial]"
passed: (1m4s) 2026-02-13T11:51:19 "[sig-mco] MCO Bootimages Author:sregidor-NonHyperShiftHOST-NonPreRelease-Medium-81403-[P1][OnCLayer] In BootImages Machineset should update by default [Disruptive] [Serial]"

started: (0/4/11) "[sig-mco] MCO Bootimages Author:ptalgulk-NonHyperShiftHOST-NonPreRelease-High-81395-[P1] Verify in boot-image by default update is opt-in. [Disruptive] [Serial]"
passed: (51.5s) 2026-02-13T11:52:11 "[sig-mco] MCO Bootimages Author:ptalgulk-NonHyperShiftHOST-NonPreRelease-High-81395-[P1] Verify in boot-image by default update is opt-in. [Disruptive] [Serial]"

No issues were found.

Please, could you apply these changes to the tests so that the bootimages tests that check the default behaviour are executed in Azure and Vsphere when we merge this PR?
main...sergiordlr:machine-config-operator:executed_default_bootimages_update_tests_in_azure_and_vspehere

@djoshy djoshy force-pushed the azure-vsphere-opt-out branch from ca423dc to d98db2f Compare February 13, 2026 15:00
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

Please, could you apply these changes to the tests so that the bootimages tests that check the default behaviour are executed in Azure and Vsphere when we merge this PR?
main...sergiordlr:machine-config-operator:executed_default_bootimages_update_tests_in_azure_and_vspehere

I have merged this with the last commit as it was also to do with e2es. Thank you for calling that one out!

@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2
  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cfe08d20-08ec-11f1-868f-f302ea5dd79a-0

Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [djoshy,isabella-janssen,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

/retest

1 similar comment
@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@sergiordlr: This PR was included in a payload test run from #5661
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/feb7f4a0-08fe-11f1-91c3-92ac59a9c770-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@sergiordlr: This PR was included in a payload test run from #5661
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/092c7ff0-08ff-11f1-80c1-cfb320f83b55-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@sergiordlr: This PR was included in a payload test run from #5661
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/11adc6c0-08ff-11f1-9674-18e18d62b316-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@sergiordlr: This PR was included in a payload test run from #5661
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19223170-08ff-11f1-8891-966d4de86d98-0

@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/39c2e870-0904-11f1-86d2-fcb877ee957f-0

@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

/retest

@djoshy
Copy link
Contributor Author

djoshy commented Feb 13, 2026

/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4d04c040-091b-11f1-9c8f-0c6a1ebf6a31-0

@djoshy
Copy link
Contributor Author

djoshy commented Feb 14, 2026

Disruptive payload runs look good.

/verified by @sergiordlr

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 14, 2026
@openshift-ci-robot
Copy link
Contributor

@djoshy: This PR has been marked as verified by @sergiordlr.

Details

In response to this:

Disruptive payload runs look good.

/verified by @sergiordlr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants