MCO-2036: Enable boot image updates by default for vsphere and Azure#5583
MCO-2036: Enable boot image updates by default for vsphere and Azure#5583djoshy wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
@djoshy: This pull request references MCO-2036 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@djoshy: This pull request references MCO-2036 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive |
|
@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fcd17e20-f636-11f0-9b60-3c66bfc66382-0 |
|
/hold we also need to reconcile the disruptive boot image tests when we enable these platforms by default, similar to openshift/origin#30712 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 #5583 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b688eb0-f874-11f0-804b-b09532f7bee8-0 |
|
@djoshy: This PR was included in a payload test run from #5583
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b688eb0-f874-11f0-804b-b09532f7bee8-0 |
|
/payload-abort |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 #5428 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b1a46080-f874-11f0-9b01-9954da0d5f2e-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2 #5428 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b51b37c0-f874-11f0-8ef4-e8cbff9ca2ef-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 #5428 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2 #5428 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c0bf6970-f874-11f0-9e49-5df462546e97-0 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c3f7b110-f874-11f0-9f8c-7baaab3813ed-0 |
|
/payload-abort |
4812e55 to
64a18b3
Compare
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2 |
|
@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cd9efc20-f886-11f0-8155-2ad31ce2de83-0 |
64a18b3 to
1a3bcbf
Compare
|
/lgtm |
|
Vsphere: This is the default configuration now: All e2e bootimages update test cases passed. Including the default test cases which are not skipped anymore in vsphere and azure. Azure: This is the default configuration now: All e2e bootimages update and controlplanemachineset test cases passed. Including the default test cases which are not skipped anymore in vsphere and azure. No issues were found. Please, could you apply these changes to the tests so that the bootimages tests that check the default behaviour are executed in Azure and Vsphere when we merge this PR? |
ca423dc to
d98db2f
Compare
I have merged this with the last commit as it was also to do with e2es. Thank you for calling that one out! |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-2of2 |
|
@djoshy: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cfe08d20-08ec-11f1-868f-f302ea5dd79a-0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@sergiordlr: This PR was included in a payload test run from #5661
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/feb7f4a0-08fe-11f1-91c3-92ac59a9c770-0 |
|
@sergiordlr: This PR was included in a payload test run from #5661
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/092c7ff0-08ff-11f1-80c1-cfb320f83b55-0 |
|
@sergiordlr: This PR was included in a payload test run from #5661
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/11adc6c0-08ff-11f1-9674-18e18d62b316-0 |
|
@sergiordlr: This PR was included in a payload test run from #5661
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19223170-08ff-11f1-8891-966d4de86d98-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/39c2e870-0904-11f1-86d2-fcb877ee957f-0 |
|
/retest |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive-techpreview-1of2 |
|
@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4d04c040-091b-11f1-9c8f-0c6a1ebf6a31-0 |
|
Disruptive payload runs look good. /verified by @sergiordlr |
|
@djoshy: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- What I did
This PR enables boot image updates by default for Azure and vsphere, and adjusts any test behavior to account for this:
- How to verify it
An installation on this PR should show the managedBootImageStatus MachineConfiguration object set to
Allfor MAPI MachineSet objects:As a result, boot image updates should took place automatically without a
spec.managedBootImagesfield defined. Any edits to the boot images defined in the MachineSet will be stomped back to the reference defined by thecoreos-bootimagesconfigmap.