deal with current+desiredConfig that shouldn't happen #4357
Conversation
in case the currentConfig==desiredConfig and the state is Working, the sync runs, setting the state to Working (again) and then Done (after doing nothing for 20s). If the next sync runs immediately after (few ms after), I speculate there is a chance the data read from the informer is stale and the sync will read a "Working" state once more, and loop. This was observed running OCP 4.12.36 on a large OpenStack deployment with some high latency. During application of machineconfigs some nodes seem to transition between Done and Working states hundreds of times, logging the "current+desiredConfig" log. Sending this commit so hopefully someone more knowledgeable could review whether this scenario is probable.
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @freedge. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: freedge The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
in case the currentConfig==desiredConfig and the state is Working, the sync runs, setting the state to Working (again) and then Done (after doing nothing for 20s).
If the next sync runs immediately after (few ms after), I speculate there is a chance the data read from the informer is stale and the sync will read a "Working" state once more, and loop.
This was observed running OCP 4.12.36 on a large OpenStack deployment with some high latency. During application of machineconfigs some nodes seem to transition between Done and Working states hundreds of times, logging the "current+desiredConfig" log.
Sending this commit so hopefully someone more knowledgeable could review whether this scenario is probable.
- What I did
- How to verify it
- Description for the changelog