OCPBUGS-45214: STOR-2285: Add groupsnapshot tests

[jsafrane]

Add e2e test for volume group snapshots.

There are several commits:

• Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
• Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
• Carry: Regenerate test annotations

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• a027a96|128972: does not specify an upstream backport in the commit message
• a21f7d6|: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[gnufied]

Once 1.32 rebase lands we don't need kubernetes#126326 right?

[jsafrane]

Yes, kubernetes#126326 is only for Kubernetes 1.31

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 0711f08|128972 from 2024-12-16: does not specify an upstream backport in the commit message
• a21f7d6|: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 33cedfd|128972 from 2024-12-16: does not specify an upstream backport in the commit message
• a21f7d6|: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 33cedfd|128972 from 2024-12-16: does not specify an upstream backport in the commit message
• 7683d8f|UPSTREAM: : regenerate test annotations: does not specify an upstream backport in the commit message
• a21f7d6|: does not specify an upstream backport in the commit message
• f09528f|UPSTREAM: : enable group snapshots by default: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 0279cb6|UPSTREAM: : enable group snapshots by default: does not specify an upstream backport in the commit message
• 5a233fd|UPSTREAM: : regenerate test annotations: does not specify an upstream backport in the commit message
• a21f7d6|: does not specify an upstream backport in the commit message
• acc737e|UPSTREAM: 128972: Add crd from external snapshotter: the upstream PR kubernetes/kubernetes#128972 has not yet merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

• 1a16529|UPSTREAM: 126326: Add end-to-end tests for Volume Group Snapshot: the upstream PR kubernetes/kubernetes#126326 has merged

The following commits could not be validated and must be approved by a top-level approver:

• 6e4f9f3|UPSTREAM: : regenerate test annotations: does not specify an upstream backport in the commit message
• 8721859|UPSTREAM: 128972: Add crd from external snapshotter: the upstream PR kubernetes/kubernetes#128972 has not yet merged
• fbe715a|UPSTREAM: : enable group snapshots by default: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

• Upstream 126326 + 128972 that add the e2e test. Only the second commit is needed in Kubernetes 1.32, but we still have 1.31 in o/k.
• Regenerate test annotations.
• In the last commit, force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases. This affects only e2e test manifests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

• Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
• Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
• Carry: Regenerate test annotations.
• Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/test

[jsafrane]

A lot of tests failed because of they failed to pull images, e.g.
Failed: Failed to pull image "quay.io/openshift/community-e2e-images:e2e-53-registry-k8s-io-e2e-test-images-busybox-1-29-2-ZYWRth-o9U_JR2ZE": initializing source docker://quay.io/openshift/community-e2e-images:e2e-53-registry-k8s-io-e2e-test-images-busybox-1-29-2-ZYWRth-o9U_JR2ZE: reading manifest e2e-53-registry-k8s-io-e2e-test-images-busybox-1-29-2-ZYWRth-o9U_JR2ZE in quay.io/openshift/community-e2e-images: manifest unknown

[jsafrane]

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

I added a commit with new images

[openshift-ci]

@jsafrane: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
• periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
• periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/77176fd0-d286-11ef-966b-e2b60ed3df72-0

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

• 66c0c64|UPSTREAM: 128972: Add crd from external snapshotter: the upstream PR kubernetes/kubernetes#128972 has merged

The following commits could not be validated and must be approved by a top-level approver:

• eb2b726|UPSTREAM: : regenerate test annotations: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

• Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
• Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
• Carry: Regenerate test annotations (applies only to 1.31)
• Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

• Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
• Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
• Carry: Regenerate test annotations

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

• 66c0c64|UPSTREAM: 128972: Add crd from external snapshotter: the upstream PR kubernetes/kubernetes#128972 has merged

The following commits could not be validated and must be approved by a top-level approver:

• 84d68f2|UPSTREAM: : Disable VolumeGroupSnapshot tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[jsafrane]

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

[openshift-ci]

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b2cae80-defe-11ef-810c-1174ef36c8c5-0

[openshift-ci-robot]

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

• 9109e3a|UPSTREAM: 128972: Add crd from external snapshotter: the upstream PR kubernetes/kubernetes#128972 has merged

The following commits could not be validated and must be approved by a top-level approver:

• 7dc2610|UPSTREAM: : Disable VolumeGroupSnapshot tests: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	7dc2610	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-fips	7dc2610	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-cgroupsv2	7dc2610	link	true	/test e2e-aws-ovn-cgroupsv2
ci/prow/integration	7dc2610	link	true	/test integration
ci/prow/e2e-aws-crun-wasm	7dc2610	link	true	/test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-serial	7dc2610	link	true	/test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-runc	7dc2610	link	true	/test e2e-aws-ovn-runc
ci/prow/e2e-aws-csi	7dc2610	link	false	/test e2e-aws-csi
ci/prow/k8s-e2e-conformance-aws	7dc2610	link	true	/test k8s-e2e-conformance-aws
ci/prow/k8s-e2e-aws-ovn-serial	7dc2610	link	false	/test k8s-e2e-aws-ovn-serial
ci/prow/e2e-gcp	7dc2610	link	true	/test e2e-gcp
ci/prow/e2e-aws-ovn-crun	7dc2610	link	true	/test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-hypershift	7dc2610	link	true	/test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-45214, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

• Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
• Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
• Carry: Regenerate test annotations

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@bertinatto: This PR was included in a payload test run from openshift/origin#29450
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61165130-ea3a-11ef-984e-a341f0ef8c16-0