Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-50899: PowerVS: COS eu-es hack #9490

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Feb 15, 2025

If the COS location to use is different than the VPC region, then we need to rename the bucket name to correctly download the image.

If the COS location to use is different than the VPC region, then we
need to rename the bucket name to correctly download the image.
@hamzy hamzy changed the title PowerVS: cos eu-es hack PowerVS: COS eu-es hack Feb 15, 2025
@openshift-ci openshift-ci bot requested review from mjturek and mkumatag February 15, 2025 00:23
@hamzy
Copy link
Contributor Author

hamzy commented Feb 15, 2025

/test e2e-powervs-capi-ovn

@hamzy
Copy link
Contributor Author

hamzy commented Feb 15, 2025

/test okd-scos-images

@hamzy
Copy link
Contributor Author

hamzy commented Feb 15, 2025

/assign @sadasu

@hamzy
Copy link
Contributor Author

hamzy commented Feb 15, 2025

/test e2e-powervs-capi-ovn

1 similar comment
@hamzy
Copy link
Contributor Author

hamzy commented Feb 16, 2025

/test e2e-powervs-capi-ovn

@hamzy hamzy changed the title PowerVS: COS eu-es hack OCPBUGS-50899: PowerVS: COS eu-es hack Feb 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 16, 2025
@openshift-ci-robot
Copy link
Contributor

@hamzy: This pull request references Jira Issue OCPBUGS-50899, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juliemathew

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the COS location to use is different than the VPC region, then we need to rename the bucket name to correctly download the image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 16, 2025
Copy link
Contributor

openshift-ci bot commented Feb 16, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juliemathew.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@hamzy: This pull request references Jira Issue OCPBUGS-50899, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juliemathew

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the COS location to use is different than the VPC region, then we need to rename the bucket name to correctly download the image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AshwinHIBM
Copy link
Contributor

lgtm

@mjturek
Copy link
Contributor

mjturek commented Feb 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@patrickdillon
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 4038f29 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-externallb-ovn 4038f29 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-powervs-capi-ovn 4038f29 link false /test e2e-powervs-capi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7eea206 and 2 for PR HEAD 4038f29 in total

@openshift-merge-bot openshift-merge-bot bot merged commit dcaf668 into openshift:main Feb 20, 2025
17 of 20 checks passed
@openshift-ci-robot
Copy link
Contributor

@hamzy: Jira Issue OCPBUGS-50899: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-50899 has been moved to the MODIFIED state.

In response to this:

If the COS location to use is different than the VPC region, then we need to rename the bucket name to correctly download the image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202502200708.p0.gdcaf668.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202502200708.p0.gdcaf668.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202502200708.p0.gdcaf668.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202502201237.p0.gdcaf668.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants