Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-1137: Enable TLS for ironic API in the bootstrap VM #9189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MahnoorAsghar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2024

@MahnoorAsghar: This pull request references METAL-1137 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MahnoorAsghar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2024

@MahnoorAsghar: This pull request references METAL-1137 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dtantsur
Copy link
Member

dtantsur commented Nov 8, 2024

Do we have any strong reasons to generate a new certificate? We even called the previous one IronicTLSCert assuming it will be used not just for virtual media.

@MahnoorAsghar
Copy link
Contributor Author

@dtantsur Thats a good question - I thought that's the way things should be: two separate certificates for 2 separate TLSs, but we could use the same one

Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MahnoorAsghar
Copy link
Contributor Author

/retest
They're all failing with this error:

could not run steps: step e2e-aws-ovn failed: failed to acquire lease for "aws-quota-slice": status 502 Bad Gateway, status code 502

@dtantsur
Copy link
Member

dtantsur commented Nov 8, 2024

I think a few more changes might be required:

  1. Changing the URL we're passing to BMO

  2. Adding IRONIC_INSECURE to various containers that cannot verify the certificate (BMO, most likely Ironic itself - for IPA).

@MahnoorAsghar
Copy link
Contributor Author

(I'm unsure about the last patch I pushed, will take a deeper look later, most likely :))

Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@MahnoorAsghar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-virtualmedia b76a2ae link false /test e2e-metal-ipi-ovn-virtualmedia
ci/prow/e2e-metal-ipi-ovn b76a2ae link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-swapped-hosts b76a2ae link false /test e2e-metal-ipi-ovn-swapped-hosts
ci/prow/e2e-metal-ipi-ovn-dualstack b76a2ae link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn-ipv6 b76a2ae link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants