-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
METAL-1137: Enable TLS for ironic API in the bootstrap VM #9189
base: master
Are you sure you want to change the base?
METAL-1137: Enable TLS for ironic API in the bootstrap VM #9189
Conversation
@MahnoorAsghar: This pull request references METAL-1137 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@MahnoorAsghar: This pull request references METAL-1137 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Do we have any strong reasons to generate a new certificate? We even called the previous one |
@dtantsur Thats a good question - I thought that's the way things should be: two separate certificates for 2 separate TLSs, but we could use the same one |
302b9d7
to
149270d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
|
I think a few more changes might be required:
|
149270d
to
b76a2ae
Compare
(I'm unsure about the last patch I pushed, will take a deeper look later, most likely :)) |
@MahnoorAsghar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.