-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Creates VPEs as needed for Disconnected install #9165
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We also need DNSServices for disconnected (the ingress operator uses it) |
20022e2
to
0d16d14
Compare
/test golint |
79f34d0
to
abdd8b3
Compare
if in.InstallConfig.Config.Publish == types.InternalPublishingStrategy && | ||
(len(in.InstallConfig.Config.ImageDigestSources) > 0 || len(in.InstallConfig.Config.DeprecatedImageContentSources) > 0) { | ||
vpcID := *powerVSCluster.Status.VPC.ID | ||
logrus.Debugf("InfraReady: Ensuring VPE gateway for IAM in VPC %v", vpcID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log is inaccurate, make it clear that multiple gateways are being created (IAM, COS, DNS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected in the latest force-push. PTAL.
97fa113
to
61c4b42
Compare
61c4b42
to
3fc5784
Compare
Signed-off-by: Hiro Miyamoto <[email protected]>
3fc5784
to
d322aea
Compare
@miyamotoh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
For Disconnected install on PowerVS, Virtual Private Endpoint Gateways (VPEs) must be created in the VPC that would be part of the infrastructure to allow traffic to the following private IBM Cloud endpoints;
Proposed code would first check if the necessary VPEs are already in place, comparing the target's CRN, and create one only when missing.
Destroy logic for the below resources need to be developed (later);