Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Creates VPEs as needed for Disconnected install #9165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miyamotoh
Copy link
Contributor

@miyamotoh miyamotoh commented Nov 1, 2024

For Disconnected install on PowerVS, Virtual Private Endpoint Gateways (VPEs) must be created in the VPC that would be part of the infrastructure to allow traffic to the following private IBM Cloud endpoints;

  • IAM
  • COS (in the region)
  • DNS services

Proposed code would first check if the necessary VPEs are already in place, comparing the target's CRN, and create one only when missing.
Destroy logic for the below resources need to be developed (later);

  • Reserved IPs (on the subnet)
  • VPEs (in the VPC)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2024
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rwsu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mjturek
Copy link
Contributor

mjturek commented Nov 4, 2024

We also need DNSServices for disconnected (the ingress operator uses it)

@miyamotoh miyamotoh force-pushed the create-vpes-for-disconnected branch 2 times, most recently from 20022e2 to 0d16d14 Compare November 5, 2024 15:09
@miyamotoh
Copy link
Contributor Author

/test golint

@miyamotoh miyamotoh force-pushed the create-vpes-for-disconnected branch 4 times, most recently from 79f34d0 to abdd8b3 Compare November 7, 2024 12:43
if in.InstallConfig.Config.Publish == types.InternalPublishingStrategy &&
(len(in.InstallConfig.Config.ImageDigestSources) > 0 || len(in.InstallConfig.Config.DeprecatedImageContentSources) > 0) {
vpcID := *powerVSCluster.Status.VPC.ID
logrus.Debugf("InfraReady: Ensuring VPE gateway for IAM in VPC %v", vpcID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log is inaccurate, make it clear that multiple gateways are being created (IAM, COS, DNS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected in the latest force-push. PTAL.

@miyamotoh miyamotoh force-pushed the create-vpes-for-disconnected branch 2 times, most recently from 97fa113 to 61c4b42 Compare November 7, 2024 15:50
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

@miyamotoh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/golint 3fc5784 link true /test golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants