Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-875: Authenticate agents #8395

Merged
merged 1 commit into from
Jul 9, 2024
Merged

AGENT-875: Authenticate agents #8395

merged 1 commit into from
Jul 9, 2024

Conversation

pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented May 11, 2024 •
edited
Loading

  • Set JWT token in the expected env var AGENT_AUTH_TOKEN
  • Set authorization header in the API requests

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 11, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 11, 2024 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pawanpinjarkar
Copy link
Contributor Author

/hold

@pawanpinjarkar pawanpinjarkar marked this pull request as ready for review May 11, 2024 01:19
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 11, 2024
@openshift-ci openshift-ci bot requested review from bfournie and zaneb May 11, 2024 01:20
@pawanpinjarkar pawanpinjarkar mentioned this pull request May 13, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • Set JWT token in the expected env var PULL_SECRET_TOKEN
  • Set authorization header in the API requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

/hold cancel

@pawanpinjarkar
Copy link
Contributor Author

/cc @rwsu @andfasano

@openshift-ci openshift-ci bot requested review from andfasano and rwsu May 13, 2024 14:16
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@zaneb zaneb mentioned this pull request May 15, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024 •
edited by openshift-ci bot
Loading

@pawanpinjarkar: This pull request references AGENT-875 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • Set JWT token in the expected env var AGENT_AUTH_TOKEN
  • Set authorization header in the API requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented May 16, 2024 •
edited
Loading

To test the authentication feature, this and other code changes from relevant PRs need to work together.
Please note, this PR only adds the code necessary to authenticate agent service, however, the complete functionality to work end to end depends on below PRs

And most importantly, updating the auth type env var

@pawanpinjarkar pawanpinjarkar mentioned this pull request May 16, 2024
Merged
@pawanpinjarkar pawanpinjarkar requested a review from zaneb May 16, 2024 22:26
@pawanpinjarkar pawanpinjarkar force-pushed the authenticate-agent-service branch 2 times, most recently from 4fe147f to 3ae28e8 Compare June 6, 2024 01:34
@pawanpinjarkar
Copy link
Contributor Author

/retest-required

rwsu
rwsu reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@bfournie
Copy link
Contributor

bfournie commented Jul 8, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024 •
edited
Loading

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-appliance 779715e link false /test e2e-agent-compact-ipv4-appliance
ci/prow/e2e-vsphere-ovn-upi 4fe147f link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-agent-ha-dualstack 1119bb1 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 1119bb1 link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/okd-e2e-agent-compact-ipv4 1119bb1 link false /test okd-e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pawanpinjarkar
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit a8b4b1c into openshift:master Jul 9, 2024
22 of 25 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202407091212.p0.ga8b4b1c.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu left review comments

@bfournie bfournie Awaiting requested review from bfournie

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@rwsu rwsu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pawanpinjarkar @openshift-ci-robot @bfournie @openshift-bot @zaneb @rwsu