Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1558: use openshift/api instead of thirdparty for machineconfig #3983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HOSTEDCP-1558: use openshift/api instead of thirdparty for machineconfig #3983

wants to merge 1 commit into from
+12,170 −32

Conversation

stevekuznetsov
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2024
@openshift-ci-robot
Copy link

@stevekuznetsov: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels May 3, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-upstream-machineconfig branch from a15e836 to eb235e9 Compare May 3, 2024 16:34
@celebdor
Copy link
Contributor

celebdor commented May 6, 2024 •
edited by openshift-ci bot

/retitle HOSTEDCP-1558: use openshift/api instead of thirdparty for machineconfig

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented May 6, 2024 •
edited by openshift-ci bot

/retitle HOSTEDCP-1558: use openshift/api instead of thirdparty for machineconfig
/assign @enxebre

@openshift-ci openshift-ci bot changed the title NO-JIRA: *: use openshift/api instead of thirdparty for machineconfig HOSTEDCP-1558: use openshift/api instead of thirdparty for machineconfig May 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024 •
edited by openshift-ci bot

@stevekuznetsov: This pull request references HOSTEDCP-1558 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-upstream-machineconfig branch from eb235e9 to 7f08399 Compare May 6, 2024 16:48
@enxebre
Copy link
Member

enxebre commented May 7, 2024

Thanks!
/approve
/hold
to wait for 4.17

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@csrwng
Copy link
Contributor

csrwng commented May 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@stevekuznetsov
Copy link
Contributor Author

/hold cancel
/retest
/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2024 •
edited by openshift-ci bot

@stevekuznetsov: This pull request references HOSTEDCP-1558 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

/hold cancel
/retest
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/use-upstream-machineconfig branch from 7f08399 to 98d6175 Compare May 20, 2024 14:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c698d1d and 2 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c5401ca and 1 for PR HEAD 98d6175 in total

@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f91af53 and 0 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/hold

Revision 98d6175 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@bryan-cox
Copy link
Member

/unhold

@bryan-cox
Copy link
Member

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 08682cb and 2 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d10c82 and 1 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4148e4d and 0 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/hold

Revision 98d6175 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@bryan-cox
Copy link
Member

/retest

@bryan-cox
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@bryan-cox
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7a5ad00 and 2 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 41fe333 and 1 for PR HEAD 98d6175 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 239a333 and 0 for PR HEAD 98d6175 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 98d6175 link false /test e2e-azure
ci/prow/e2e-kubevirt-azure-ovn 98d6175 link false /test e2e-kubevirt-azure-ovn
ci/prow/verify 98d6175 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 98d6175 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@enxebre enxebre

@csrwng csrwng

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stevekuznetsov @openshift-ci-robot @celebdor @enxebre @csrwng @bryan-cox