Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1683: Use go workspaces #3980

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

muraee
Copy link
Contributor

@muraee muraee commented May 3, 2024

What this PR does / why we need it:
This solves 2 problems which were introduced when we moved our API to a separate sub module:

  1. Duplicate API files: currently all our API is vendored in the main module.
  2. API imports in our code are using the vendored version which led to poor UX because local changes to the API are not being reflected immediately in the code until the vendor dir is updated. Also using the IDE "go to" feature will send you to the vendor folder where you can't do any updates/changes.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2024
@openshift-ci-robot
Copy link

@muraee: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
This solves 2 problems which were introduced when we moved our API to a separate sub module:

  1. Duplicate API files: currently all our API is vendored in the main module.
  2. API imports in our code are using the vendored version which led poor UX because local changes to the API is not being reflected immediately in the code until the vendor dir is updated. Also using the IDE "go to" feature will send you the vendor folder where you can't do any updates/changes.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@muraee
Copy link
Contributor Author

muraee commented May 3, 2024

/hold
requires golang-1.22 base image registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.22-openshift-4.17 which we can use after the Branch Cut

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 22, 2024
@muraee muraee force-pushed the use-go-workspaces branch 3 times, most recently from d483460 to 5dfeed4 Compare May 22, 2024 14:18
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 22, 2024
@muraee
Copy link
Contributor Author

muraee commented May 22, 2024

/retest-required

@muraee muraee changed the title NO-JIRA: Use go workspaces HOSTEDCP-1683: Use go workspaces May 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2024

@muraee: This pull request references HOSTEDCP-1683 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
This solves 2 problems which were introduced when we moved our API to a separate sub module:

  1. Duplicate API files: currently all our API is vendored in the main module.
  2. API imports in our code are using the vendored version which led to poor UX because local changes to the API are not being reflected immediately in the code until the vendor dir is updated. Also using the IDE "go to" feature will send you to the vendor folder where you can't do any updates/changes.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@muraee muraee force-pushed the use-go-workspaces branch 2 times, most recently from 897e8e2 to b4c97f9 Compare May 23, 2024 16:06
Copy link
Contributor

openshift-ci bot commented May 27, 2024

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 2fe0358 link true /test images
ci/prow/e2e-kubevirt-aws-ovn 2fe0358 link true /test e2e-kubevirt-aws-ovn
ci/prow/verify 2fe0358 link true /test verify
ci/prow/e2e-azure 2fe0358 link false /test e2e-azure
ci/prow/e2e-ibmcloud-iks 2fe0358 link false /test e2e-ibmcloud-iks
ci/prow/e2e-kubevirt-azure-ovn 2fe0358 link false /test e2e-kubevirt-azure-ovn
ci/prow/e2e-aws 2fe0358 link true /test e2e-aws
ci/prow/unit 2fe0358 link true /test unit
ci/prow/e2e-ibmcloud-roks 2fe0358 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants