Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32979: Update network operator status for IPsec #2360

Merged
merged 1 commit into from May 16, 2024
Merged

OCPBUGS-32979: Update network operator status for IPsec #2360

merged 1 commit into from May 16, 2024

Conversation

pperiyasamy
Copy link
Member

@pperiyasamy pperiyasamy commented Apr 26, 2024 •
edited

This PR updates network operator progressing condition for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

@openshift-ci openshift-ci bot requested review from trozet and tssurya April 26, 2024 08:55
@pperiyasamy
Copy link
Member Author

/assign @jcaamano @kyrtapz

@pperiyasamy pperiyasamy changed the title Update network operator status for IPsec OCPBUGS-32979: Update network operator status for IPsec Apr 30, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-32979, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR updates network operator's progressing and degraded conditions for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-32979, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-32979, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

This PR updates network operator's progressing and degraded conditions for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

Depends on: #2349

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcaamano
jcaamano reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jcaamano jcaamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @kyrtapz @pliurh

I would like commit 2 general opinion here and also in context of live migration which is another functionality that depends on pool status.

I think we should reconcile on pool status changes, but regardless this makes sense.

@jcaamano
Copy link
Contributor

@pperiyasamy please note that this will delay installs if ipsec is enabled from the get go, possibly delaying them over an installer global timeout and making them fail. We might need to account for this in ipsec CI jobs and also in docs if the default timeout is not big enough.

@pperiyasamy
Copy link
Member Author

@pperiyasamy please note that this will delay installs if ipsec is enabled from the get go, possibly delaying them over an installer global timeout and making them fail. We might need to account for this in ipsec CI jobs and also in docs if the default timeout is not big enough.

yes @jcaamano , The ci/prow/e2e-ovn-ipsec-step-registry job is so far looking fine with change, but it would be also good to get this release PR merged (as this makes ipsec jobs to adapt with new API changes) and look for few more runs how it behaves. cc @jluhrsen

@pperiyasamy
Copy link
Member Author

/test e2e-ovn-ipsec-step-registry

@pperiyasamy
Copy link
Member Author

/test e2e-ovn-ipsec-step-registry

1 similar comment
@pperiyasamy
Copy link
Member Author

/test e2e-ovn-ipsec-step-registry

@pperiyasamy
Copy link
Member Author

This 1788117489796780032 run shows change is in effect (here) and COs are back to running in 28mins. Would try for few more runs.

@pperiyasamy
Copy link
Member Author

/test e2e-ovn-ipsec-step-registry

jcaamano
jcaamano reviewed May 13, 2024
View reviewed changes
pkg/network/ovn_kubernetes.go
@@ -268,6 +268,9 @@ func renderOVNKubernetes(conf *operv1.NetworkSpec, bootstrapResult *bootstrap.Bo
data.Data["OVNIPsecDaemonsetEnable"] = OVNIPsecDaemonsetEnable
data.Data["OVNIPsecEnable"] = OVNIPsecEnable

// Set progressing to true until IPsec DaemonSet is rendered when EW IPsec config is enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pperiyasamy can you add a TODO here explaining what we want to do in the future and/or pointing to the jira issue? thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks a lot @jcaamano and @kyrtapz for a quick offline reviews on this PR.

@pperiyasamy pperiyasamy force-pushed the report-ipsec-status branch 2 times, most recently from 807c96f to 2f27c7b Compare May 13, 2024 11:19
@pperiyasamy
Update network operator status for IPsec
763c565 
This commit updates network operator progressing condition for
rolling out IPsec daemonset for cluster. It reflects appropriate
status for network cluster operator which would make
openshift-install to exit gracefully after installing all of IPsec
components for the cluster.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy
Copy link
Member Author

/retest

@jcaamano
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9c3a57e and 2 for PR HEAD 763c565 in total

@pperiyasamy
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 15, 2024
@pperiyasamy
Copy link
Member Author

/retest

1 similar comment
@pperiyasamy
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 763c565 link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 763c565 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-ovn-ipsec-step-registry 763c565 link false /test e2e-ovn-ipsec-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0a03896 into openshift:master May 16, 2024
35 of 38 checks passed
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: Jira Issue OCPBUGS-32979: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32979 has been moved to the MODIFIED state.

In response to this:

This PR updates network operator progressing condition for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.17.0-202405161113.p0.g0a03896.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-17-180525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaamano jcaamano jcaamano left review comments

@trozet trozet Awaiting requested review from trozet

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@jcaamano jcaamano

@kyrtapz kyrtapz

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pperiyasamy @openshift-ci-robot @jcaamano @openshift-bot @openshift-merge-robot @kyrtapz