NP-974: Validation for live migration from OpenShiftSDN to OVNKubernetes #2344
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test e2e-aws-live-migration-sdn-ovn |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-live-migration-sdn-ovn |
kyrtapz
force-pushed
the
live_migration_preflight
branch
from
7904fb6
to
d9a3e48
Compare
|
/test e2e-aws-live-migration-sdn-ovn |
kyrtapz
force-pushed
the
live_migration_preflight
branch
2 times, most recently
from
f6ae361
to
2ae4a49
Compare
kyrtapz
changed the title
kyrtapz
changed the title
|
/test ? |
|
@kyrtapz: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-live-migration-sdn-ovn-rollback |
kyrtapz
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@kyrtapz: This pull request references NP-974 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
| }) | ||
| } | ||
|
|
||
| v4InternalSubnet, v6InternalSubnet := GetInternalSubnets(operConfig.Spec.DefaultNetwork.OVNKubernetesConfig) |
There was a problem hiding this comment.
Do we need to check the IPv6 subnet? We don't support IPv6 in live migration.
There was a problem hiding this comment.
I think it doesn't hurt to have if here, there is a chance that a creative user sets the IPv6 CIDRs to overlapping values before kicking of the migration right?
There was a problem hiding this comment.
We don't support SDN to dual-stack OVN migration. We may reject it here.
There was a problem hiding this comment.
The user can change the cluster to dual-stack after migrating from SDN, there is no way to make the cluster dual-stack during the migration.
I don't think that there is any harm in having the ipv6 checks in place here although I agree that this is an unlikely scenario.
kyrtapz
force-pushed
the
live_migration_preflight
branch
from
2ae4a49
to
8ab8197
Compare
|
/retest |
|
/lgtm |
Adds the following validations: - Do not allow migrating from OpenShiftSDN in multitenant mode. - Check whether any of the clusterNetwork/serviceNetwork subnets conflict the internal OVNKubernetes subnets(internal, transitstwitch and masquerade). - Do not allow migrating from OpenShiftSDN if there are any pods with pod.network.openshift.io/assign-macvlan annotation present in the cluster. Signed-off-by: Patryk Diak <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, pliurh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test ? |
|
@kyrtapz: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/retest-required |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/hold Revision d9244af was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
/cherry-pick release-4.16 release-4.15 |
|
@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/tide refresh |
|
/skip |
|
/retest-required |
|
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-azure-ovn-upgrade |
|
@kyrtapz: new pull request created: #2376 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds the following validations for OpenShiftSDN to OVNKubernetes live migration:
ClusterNetworkandServiceNetworkCIDRs conflict with the internal OVNKubernetes subnets:v[4|6]InternalSubnet,v[4|6]InternalTransitSwithSubnetandv[4|6]InternalMasquerateSubnet.with pod.network.openshift.io/assign-macvlan annotation present in the cluster.