Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-31876: Enable UDP aggregation on s390x #2331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-31876: Enable UDP aggregation on s390x #2331

wants to merge 1 commit into from
+0 −6

Conversation

werled
Copy link

@werled werled commented Apr 8, 2024 •
edited

Reverts the changes made to disable UDP aggregation in:

  • daef1a6
  • 919dba8 which specifically disable UDP aggregation on s390x.

This works now, since the changes for https://issues.redhat.com/browse/OCPBUGS-18935 have landed in https://github.com/openshift/ovn-kubernetes/ (openshift/ovn-kubernetes#2110).

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2024
@openshift-ci-robot
Copy link
Contributor

@werled: This pull request references Jira Issue OCPBUGS-2532, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts the changes made in:

  • daef1a6
  • 919dba8 which specifically disable UDP aggregation on s390x.

This works now, since the changes for https://issues.redhat.com/browse/OCPBUGS-18935 have landed in https://github.com/openshift/ovn-kubernetes/ (openshift/ovn-kubernetes#2110).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2024
@werled werled force-pushed the ocpbugs-2532-enable-udp-aggregation branch 2 times, most recently from fe62d8c to e29bf8c Compare April 8, 2024 13:56
@werled
Copy link
Author

werled commented Apr 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@werled: This pull request references Jira Issue OCPBUGS-2532, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from abhat and tssurya April 8, 2024 14:02
@werled werled changed the title [WIP] OCPBUGS-2532: Enable UDP aggregation on s390x [WIP] OCPBUGS-31876: Enable UDP aggregation on s390x Apr 8, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Apr 8, 2024
@openshift-ci-robot
Copy link
Contributor

@werled: This pull request references Jira Issue OCPBUGS-31876, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts the changes made to disable UDP aggregation in:

  • daef1a6
  • 919dba8 which specifically disable UDP aggregation on s390x.

This works now, since the changes for https://issues.redhat.com/browse/OCPBUGS-18935 have landed in https://github.com/openshift/ovn-kubernetes/ (openshift/ovn-kubernetes#2110).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@werled werled force-pushed the ocpbugs-2532-enable-udp-aggregation branch from e29bf8c to 7fb6ae7 Compare April 8, 2024 14:26
@werled
Copy link
Author

werled commented Apr 8, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@werled: This pull request references Jira Issue OCPBUGS-31876, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@werled werled force-pushed the ocpbugs-2532-enable-udp-aggregation branch 4 times, most recently from f11f49a to 465b055 Compare April 24, 2024 12:02
@werled werled changed the title [WIP] OCPBUGS-31876: Enable UDP aggregation on s390x OCPBUGS-31876: Enable UDP aggregation on s390x Apr 24, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
@werled
Copy link
Author

werled commented Apr 24, 2024

We have tested with a release based on the s390x nightly 2024-04-23-032729 with a cluster-network-operator built based on this PR; the cluster is stable and the rx-udp-gro-forwarding option is correctly enabled on the node.

# oc debug node/compute-1
[...]
sh-4.4# for x in $(ls /sys/class/net/); do echo -- $x; ethtool -k $x |grep forwarding; done
-- 1ade320022755ab
rx-udp-gro-forwarding: on
-- 24bca8c014804d6
rx-udp-gro-forwarding: on
-- 259435b91150fda
rx-udp-gro-forwarding: on
-- 56db49b3330f8d3
rx-udp-gro-forwarding: on
-- 60c66126fe7f38a
rx-udp-gro-forwarding: on
-- 6b815c995602334
rx-udp-gro-forwarding: on
-- 82567d020510242
rx-udp-gro-forwarding: on
-- 8d435840e85241f
rx-udp-gro-forwarding: on
-- 99423956be461c9
rx-udp-gro-forwarding: on
-- afc00d5f6954f10
rx-udp-gro-forwarding: on
-- bccb3a60b2bbb4a
rx-udp-gro-forwarding: on
-- br-ex
rx-udp-gro-forwarding: off
-- br-int
rx-udp-gro-forwarding: off
-- enc1
rx-udp-gro-forwarding: on
-- f53383c1b4ab6d2
rx-udp-gro-forwarding: on
-- genev_sys_6081
rx-udp-gro-forwarding: off
-- lo
rx-udp-gro-forwarding: off
-- ovn-k8s-mp0
rx-udp-gro-forwarding: off
-- ovs-system
rx-udp-gro-forwarding: off

@werled
Copy link
Author

werled commented Apr 24, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link
Contributor

@werled: This pull request references Jira Issue OCPBUGS-31876, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @djslavens

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from djslavens April 24, 2024 12:54
djslavens
djslavens approved these changes Apr 24, 2024
View reviewed changes
Copy link

@djslavens djslavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@werled werled changed the title OCPBUGS-31876: Enable UDP aggregation on s390x [WIP] OCPBUGS-31876: Enable UDP aggregation on s390x Apr 26, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@werled werled changed the title [WIP] OCPBUGS-31876: Enable UDP aggregation on s390x OCPBUGS-31876: Enable UDP aggregation on s390x Apr 26, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@werled
Copy link
Author

werled commented May 8, 2024

/retest-required

@werled
Copy link
Author

werled commented May 8, 2024

/retest

@werled
Copy link
Author

werled commented May 8, 2024

@tssurya could you please help me get this reviewed/approved? I think you know the context of the upstream changes. The failing thests should not be related to this code change (only affects s390x).

@werled
OCPBUGS-31876: Enable UDP aggregation on s390x
b2d51ec 
Reverts the changes to disable UDP aggregation made in:
* daef1a6
* 919dba8
which specifically disable UDP aggregation on s390x.

This works now, since https://issues.redhat.com/browse/OCPBUGS-18935
is fixed.

Signed-off-by: Dominik Werle <[email protected]>
@werled werled force-pushed the ocpbugs-2532-enable-udp-aggregation branch from 465b055 to b2d51ec Compare May 24, 2024 13:24
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
djslavens
djslavens approved these changes May 24, 2024
View reviewed changes
Copy link

@djslavens djslavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@kyrtapz
Copy link
Contributor

kyrtapz commented May 27, 2024

/lgtm

@jcaamano
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djslavens, jcaamano, kyrtapz, werled

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8c1af57 and 2 for PR HEAD b2d51ec in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2024

@werled: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec b2d51ec link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration b2d51ec link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-network-mtu-migration-ovn-ipv4 b2d51ec link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-ovn-ipsec-step-registry b2d51ec link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-azure-ovn b2d51ec link false /test e2e-azure-ovn
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback b2d51ec link false /test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/e2e-vsphere-ovn-dualstack b2d51ec link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 b2d51ec link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security b2d51ec link false /test security
ci/prow/e2e-aws-ovn-single-node b2d51ec link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn b2d51ec link true /test e2e-gcp-ovn
ci/prow/e2e-azure-ovn-upgrade b2d51ec link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djslavens djslavens djslavens approved these changes

@abhat abhat Awaiting requested review from abhat

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@djslavens djslavens

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@werled @openshift-ci-robot @kyrtapz @jcaamano @djslavens