Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy networking-console-plugin by CNO #2322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deploy networking-console-plugin by CNO #2322

wants to merge 1 commit into from

Conversation

orenc1
Copy link

@orenc1 orenc1 commented Mar 26, 2024 •
edited

Use the CNO operator config controller to deploy and reconcile the resources required to enable the new Networking console plugin:

  • Deployment (hosts the plugin pages contents via an nginx web server)
  • Service (exposes the webserver to the console)
  • ConfigMap (for nginx config)
  • ConsolePlugin (binds the console with the dynamic plugin)

Also, enables the console plugin by adding it to the cluster Console plugins list.

Jira ticket: https://issues.redhat.com/browse/CONSOLE-3952

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@openshift-ci openshift-ci bot requested review from dcbw and dougbtv March 26, 2024 11:49
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: orenc1
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orenc1 orenc1 force-pushed the networking_console_plugin branch 2 times, most recently from 393616f to 1c1cda6 Compare March 28, 2024 17:58
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@orenc1 orenc1 force-pushed the networking_console_plugin branch 3 times, most recently from 8aa4cb5 to ab23388 Compare March 31, 2024 13:34
@orenc1
Copy link
Author

orenc1 commented Mar 31, 2024

/test e2e-metal-ipi-ovn-ipv6

@orenc1 orenc1 force-pushed the networking_console_plugin branch 3 times, most recently from 28131a8 to dd2941b Compare April 2, 2024 17:43
@orenc1 orenc1 changed the title [WIP] Deploy networking-console-plugin by CNO Deploy networking-console-plugin by CNO Apr 3, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
@orenc1 orenc1 force-pushed the networking_console_plugin branch 6 times, most recently from 01a6a50 to cc3c51c Compare April 7, 2024 10:27
orenc1
orenc1 commented Apr 7, 2024
View reviewed changes
pkg/network/render.go
return nil, nil
}

tmpFallbackConsoleImage := "quay.io/orenc/networking-console-plugin:4.16"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like in an hypershift hosted cluster, the CNO deployment on the hosted control plane is not getting populated with the NETWORKING_CONSOLE_PLUGIN_IMAGE env var.
could you please advise how can we inject it in that case?

orenc1 added a commit to orenc1/cluster-network-operator that referenced this pull request Apr 9, 2024
@orenc1
Add networking-console-plugin image to release payload
a1199b3 
this is required so hypershift's control-plane-operator will be able to deploy CNO with this image, extracted from the release payload.

this PR is a prerequisite for openshift#2322

Signed-off-by: Oren Cohen <[email protected]>
@orenc1 orenc1 mentioned this pull request Apr 9, 2024
Open
orenc1 added a commit to orenc1/cluster-network-operator that referenced this pull request Apr 25, 2024
@orenc1
Add networking-console-plugin image to release payload
80baff5 
this is required so hypershift's control-plane-operator will be able to deploy CNO with this image, extracted from the release payload.

this PR is a prerequisite for openshift#2322

Signed-off-by: Oren Cohen <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
@gouyang
Copy link

gouyang commented May 6, 2024

@orenc1 could you catch up on this? It's a test blocker.

@orenc1
Deploy networking-console-plugin by CNO
1036192 
Use the CNO operator config controller to deploy and reconcile the resources required to enable the new Networking console plugin:
* Deployment
* Service
* ConfigMap (for nginx config)
* ConsolePlugin

Signed-off-by: Oren Cohen <[email protected]>
@orenc1 orenc1 force-pushed the networking_console_plugin branch from cc3c51c to 1036192 Compare May 9, 2024 08:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2024

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1036192 link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 1036192 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-vsphere-ovn-dualstack 1036192 link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@dougbtv dougbtv Awaiting requested review from dougbtv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orenc1 @gouyang @openshift-merge-robot