Remove extra env section in whereabouts-reconciler daemonset [ocp 4.12] #2276
Conversation
WHEREABOUTS_NAMESPACE env var was mistakenly added in a separate env section which doesn't take effect. WHEREABOUTS_NAMESPACE env var is used by whereabouts-reconciler to garbage collect the Pod IPs. When unset, it defaults to kube-system namespace, while ippool.whereabouts.cni.cncf.io custom resource only exist in openshift-multus namespace on openshift. Signed-off-by: Zenghui Shi <[email protected]>
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgoncalves, dougbtv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@dougbtv: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/label backport-risk-assessed |
|
@zshi-redhat: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/hold |
openshift-ci
bot
assigned anuragthehatter, asood-rh, eurijon, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta and rlobillo
openshift-ci
bot
added
the
do-not-merge/hold
|
This was for a supportex build only: we merged the functionality in 4.12 in #2284 |
|
/assign @weliang1 |
|
@anuragthehatter: GitHub didn't allow me to assign the following users: weliang1. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @weliang1 |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
WHEREABOUTS_NAMESPACE env var was mistakenly added in a separate env section which doesn't take effect.
WHEREABOUTS_NAMESPACE env var is used by whereabouts-reconciler to garbage collect the Pod IPs. When unset, it defaults to kube-system namespace, while ippool.whereabouts.cni.cncf.io custom resource only exist in openshift-multus namespace on openshift.