OCM-13888 | fix: Ensure labels for metrics correctly reference service name and not API version. #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having metrics generated with the following label structure for services that are not hard-coded into the label generation process:
ocm-v1. Essentially, the label is selecting the API version part of the path, rather than the service name. This is making it very hard to understand what services are receiving traffic, unless they are in the hard-coded list.This fix ensures that we select the service name from the path rather than the service version. I have explicitly decided against updating the list of hard-coded service mappings for the sake of maintenance going forward.